Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pull request by language #5563

Open
surli opened this issue Mar 3, 2021 · 5 comments
Open

Support for pull request by language #5563

surli opened this issue Mar 3, 2021 · 5 comments
Labels
enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship.

Comments

@surli
Copy link
Contributor

surli commented Mar 3, 2021

Is your feature request related to a problem? If so, please describe.

We are starting to set up in XWiki a new process when a new language is introduced in the platform because we need to perform some checks to ensure the language will be properly supported by our search engine etc.
The problem is that all contributions made in Weblate are currently sent in a unique pull request on our repository, so a pull request mixes changes related to multiple language. If we need to perform checks for adding a new language (that we see because of a pull request submission), it means that we'll block all other changes until we performed the checks (and possibly some changes in our code).

Describe the solution you'd like

It would be nice to be able to receive different pull requests depending on the language translated. It would prevent us blocking contributions in other languages when a new language is added. It would probably also help reviewing the contributions: we mainly do the review process by checking the PR.

Describe alternatives you've considered

Right now we don't see many alternatives: we are gonna block the PR until we're ready to merge them.

@nijel
Copy link
Member

nijel commented Mar 3, 2021

This would be quite complicated to implement - Weblate has one working copy of the repository and having multiple branches to allow pull requests per language would add a lot of complexity. You can always cherry-pick commits from the pull request if you don't want to merge it fully.

@surli
Copy link
Contributor Author

surli commented Mar 3, 2021

having multiple branches to allow pull requests per language would add a lot of complexity

Well I can imagine that it would be lots of work to add in Weblate, but I think it might be an interesting way to go. Supporting multi-branches could also allow some other features such as having different PR per components in case of linked components.

You can always cherry-pick commits from the pull request if you don't want to merge it fully.

Sure, but that's manual work, the idea here is to have an process more automated.

@nijel
Copy link
Member

nijel commented Mar 3, 2021

having different PR per components in case of linked components

You don't have to use linked components, and you will get separate PRs then.

@nijel nijel added enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship. labels Mar 3, 2021
@github-actions
Copy link

github-actions bot commented Mar 3, 2021

This issue has been put aside. It is currently unclear if it will ever be implemented as it seems to cover too narrow of a use case or doesn't seem to fit into Weblate. Please try to clarify the use case or consider proposing something more generic to make it useful to more users.

@nijel
Copy link
Member

nijel commented Sep 3, 2024

What might be a more generic solution to this is #7271 - each underlying repository would get a pull request, even if the repositories would be actually the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship.
Projects
None yet
Development

No branches or pull requests

2 participants