Should this be removed now?

we can remove it if we are certain we want task local to be the final way (then we can even remove the options in total or make it empty for now)

I think we would want to create a new instance of the dictionary here which takes the values in, otherwise we have the same reference to a dict under the hood which could have issues with races I think (since this is a class not a struct)

Since we are passing the dictionary into a new class, we should have a copy. Technically copy on write will make it the same instance, but it should be fine since those updates are atomic. What would be dangerous would be passing the ServiceDictionary itself, since that has a pointer to the actual same dictionary in multiple places and is definitely not sendable

I think this being static would cause multiple containers to share the same local dependency graph, is that correct?

since this is TaskLocal it only sticks around for the given task. They all have the same base wrapper (which is an empty container), but when you go into the task (using the ServiceDictionaryTaskLocal.$dictionary.withValue), it will update the value to be the new one. Here are the docs: https://developer.apple.com/documentation/swift/tasklocal

For tasks - sure, but if you are just on the main thread and have two containers I think this could lead some funkiness.

This is kind of convoluted use case but something like this would lead to some weird behavior I think:

let containerA = Container()
let containerB = Container()

// Add modules to containers

containerA.inject { module in
     module.factory { 
          let depB: DependencyB = containerB.inject { ... }
          return depB
     }
}

Is there anyway to use TaskLocal via an instance variable so it can be scoped to a container? (Also please let me know if my understanding above is incorrect).