Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diffs inside Elixir sigils #785

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Improve diffs inside Elixir sigils #785

wants to merge 24 commits into from

Conversation

crbelaus
Copy link

@crbelaus crbelaus commented Nov 18, 2024 •
edited
Loading

This pull request makes the following changes:

  1. Updates the vendored tree-sitter-elixir package
  2. Adds a few Elixir example files so we can compare diffs before and after the changes
  3. Updates the Elixir parser to consider sigils as atom nodes

This is the result (before and after):

image

Notice how after the changes, the modifications inside the ~H sigil are highlighted when previously they were not. This fixes #784

jonatanklosko and others added 23 commits December 4, 2023 13:06
@jonatanklosko
Release v0.1.1
11426c5
@jonatanklosko
Improvements
94171b8
@jonatanklosko @github-actions
Generate parser
511ea5e
@jonatanklosko
Update nan
2c2cce9
@jonatanklosko
Escape curly braces in regular expressions
a9109f5
@jonatanklosko @github-actions
Generate parser
868620e
@jonatanklosko
Update versions and requirements (Wilfred#66)
420b917
@jonatanklosko
Update CI
ab1818a
@jonatanklosko
Release v0.2.0 (Wilfred#67)
de690fa
@jonatanklosko
Support digits in uppercase sigils (Wilfred#68)
061abbb
@jonatanklosko @github-actions
Generate parser
c7ae8b7
@hendrikvanantwerpen
Update to tree-sitter 0.23 (Wilfred#70)
c0cd12e
@jonatanklosko @github-actions
Generate parser
b7efd84
@jonatanklosko
Release v0.3.0
ac7b59b
@jonatanklosko
Fix link in changelog
27efab5
@hendrikvanantwerpen
Code cleanup (Wilfred#71)
2c6e931
@jonatanklosko
Highlight field access differently from calls (Wilfred#73)
d292589
@jonatanklosko
Release v0.3.1
ef124b8
@jonatanklosko
Fix installation on CI
2ac7a0f
@bcardarella @jonatanklosko
Add support for LiveView Native template syntax highlighting (Wilfred#75
5345854 
)

Co-authored-by: Jonatan Kłosko <[email protected]>
@crbelaus
Update Elixir tree sitter parser
1b9f862
@crbelaus
Add Elixir example files
8b6a96e
@crbelaus
Consider Elixir sigils as atom nodes
1dfae2b
@crbelaus
Copy link
Author

Looks like updating the tree-sitter-elixir subtree has included many commits from that repository. Let me know if you prefer me to squash them into a single commit instead.

@crbelaus crbelaus changed the title Improve Elixir HEEx diffs Improve Elixir diffs inside sigils Nov 20, 2024
@crbelaus crbelaus changed the title Improve Elixir diffs inside sigils Improve diffs inside Elixir sigils Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changes in Elixir HEEx sigils are not highlighted
4 participants
@crbelaus @jonatanklosko @hendrikvanantwerpen @bcardarella