-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unclear about what src_top, src_left should do,... #14
Comments
Yes they are used for shifting, same as parameters |
But shouldn't they shift all planes? I first assumed that those parameters are meant to shift the focus of 'what is important',... |
The shifting of chroma channels is not clearly visible, as in the bottom right image you posted. The bottom left image contains chroma information of clip You should use the following code to compare the effect of shifting.
|
Yeah, but if all planes are shifted the same way, why is there a shift in the upper right image? |
I guess you may want to use
And each value in the array specifies shifting of one plane. |
so for YUV |
True. |
Okay, thanks for clearing that up, I didn't get that from the description. :) |
Sorry about that. I try to clarify it in a new commit. |
No problem. |
In
Plane 0 and 2 of |
Thanks, for explaining. :) |
Since I don't get the description I tried to figure out what the parameters do.
Using:
I got this https://i.postimg.cc/prq7qMVQ/src-left.png
To me it looks like only one plane of the color is shifted, is this a bug or intended?
=> Would be nice if you could share some details on what those parameters should do. Thanks.
The text was updated successfully, but these errors were encountered: