The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: ntsekouras <[email protected]>
Co-authored-by: andreawetzel <[email protected]>
Co-authored-by: himanshupathak95 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Based on the method comment, I think the behavior is intentional. Variations and patterns need to specify if they're not using an inherit query.

@ntsekouras, can you firm this?

Based on the method comment, I think the behavior is intentional. Variations and patterns need to specify if they're not using an inherit query.

@ntsekouras, can you firm this?

That's what I thought too. But even if the inherit value is set to false, it gets overwritten to true, and this in turn overrides the perPage already set in the pattern to a more generic value set in reading settings or defaults to just 10.

I think the perPage if declared inside the pattern must be prioritised over the more generic reading settings.

Or perhaps, we can use this approach:

block.attributes.query = {
  ...block.attributes.query,
  postType,
  inherit: block.attributes.query.inherit ?? inherit,
};

Here, if the inherit value is omitted altogether, we can use the default inherit value of the query block.

Please let me know which direction to proceed with so that I can make the changes accordingly in the proposed PR.

Thanks for the PR! I think it makes sense to preserve the inherit value (as is in trunk), since the pattern should be more about presentation and not changing such values. I may be misunderstanding the issue here but are you having a problem when you have a custom(inherit:false) Query Loop and choose a pattern which also contains a custom one?

Just noting some recent updates that might be relevant here:

1. the default inherit value changed
2. some logic was introduced inside an effect to enforce inherit value in some cases.

I'll cc @mikachan as well for any thoughts.

The change to the default value of inherit is an issue for patterns that include multiple queries such as the Twenty Twenty Four pattern Grid of posts featuring the first post, 2 columns because the second query is intended to have an offset number to match the queried post number from the first query.