From d4d8c75ef3e012316dfc3c7c1216a1cfda432535 Mon Sep 17 00:00:00 2001
From: qianlifeng <qianlf2010@gmail.com>
Date: Sat, 2 Mar 2024 10:05:22 +0800
Subject: [PATCH] Refactor plugin directory validation & deduplication

Updated the logic to check for invalid plugin directories: besides removing those that failed the `stat` operaton, the code now also cleans duplicates. Furthermore, when adding local plugins, it now checks if the plugin directory has already been added to localPluginDirectories, avoiding unnecessary repetition.
---
 Wox/plugin/system/wpm.go | 26 ++++++++++++++++++--------
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/Wox/plugin/system/wpm.go b/Wox/plugin/system/wpm.go
index 97e616394..f4627a56c 100644
--- a/Wox/plugin/system/wpm.go
+++ b/Wox/plugin/system/wpm.go
@@ -111,17 +111,21 @@ func (w *WPMPlugin) Init(ctx context.Context, initParams plugin.InitParams) {
 		return
 	}
 
-	// remove invalid directories
-	w.localPluginDirectories = lo.Filter(localPluginDirs, func(directory string, _ int) bool {
-		_, statErr := os.Stat(directory)
-		if statErr != nil {
+	// remove invalid and duplicate directories
+	var pluginDirs []string
+	for _, pluginDir := range localPluginDirs {
+		if _, statErr := os.Stat(pluginDir); statErr != nil {
 			w.api.Log(ctx, plugin.LogLevelWarning, fmt.Sprintf("Failed to stat local plugin directory, remove it: %s", statErr.Error()))
-			os.RemoveAll(directory)
-			return false
+			os.RemoveAll(pluginDir)
+			continue
 		}
-		return true
-	})
 
+		if !lo.Contains(pluginDirs, pluginDir) {
+			pluginDirs = append(pluginDirs, pluginDir)
+		}
+	}
+
+	w.localPluginDirectories = pluginDirs
 	for _, directory := range w.localPluginDirectories {
 		w.loadDevPlugin(ctx, directory)
 	}
@@ -433,6 +437,12 @@ func (w *WPMPlugin) addCommand(ctx context.Context, query plugin.Query) []plugin
 	}
 
 	pluginDirectory := pluginDirectories[0]
+
+	if lo.Contains(w.localPluginDirectories, pluginDirectory) {
+		w.api.Notify(ctx, "Already added", "The plugin directory has already been added")
+		return []plugin.QueryResult{}
+	}
+
 	w.api.Log(ctx, plugin.LogLevelInfo, fmt.Sprintf("Add local plugin: %s", pluginDirectory))
 	w.localPluginDirectories = append(w.localPluginDirectories, pluginDirectory)
 	w.saveLocalPluginDirectories(ctx)