Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open to reorganize LilyGo-specific library #34

Open
rrainey opened this issue Oct 7, 2022 · 1 comment
Open

Open to reorganize LilyGo-specific library #34

rrainey opened this issue Oct 7, 2022 · 1 comment

Comments

@rrainey
Copy link

rrainey commented Oct 7, 2022

I have encountered several recent issues keeping the LilyGo specific enhancements to the standard GxEPD library synchronized and up-to-date. It's just not very clean to be manually copying the LilyGo "lib" folder into the Arduino libraries tree by hand. I have a proposal: how about pulling boards.h and associated LilyGo-specific subfolders into a fresh library that logically lays atop GxEPD rather than trying to maintain a separate fork? This new library would be constructed as a standard Arduino library, so the extra dependent libraries could be declared as such.

What are your thoughts on this?
@mrWheel
Copy link

mrWheel commented Oct 7, 2022

YES!

I'm for it!

I totally removed the boards.h file and included the definitions for my board in de sketch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rrainey @mrWheel