Allow offsets on center-column / changing what counts as "center of the monitor"

[applejag]

I have a ultrawide screen with a second vertical screen next to it. Here's a preview of the monitor layout as showed by KDE's monitor config:

Because of this I have the monitors layed out so I sit to the left of the ultrawide monitor:

When I only have a single window open and press Mod+C to get it centered (triggering center-column action) the window is not right in front of me, but instead slightly to the right.

This is a very niche issue, I know 😅 but it would be nice to be able to configure what counts as "center of the screen" for the center-column action and the center-focused-column layout config. This would then also be a per-monitor setting for heterogeneous monitor setups.

How I imagine it is configs like:

layout {
    center-focused-column "always"
}

output "eDP-1" {
    mode "5120x1440@60"
    position x=1440 y=544

    // Here's the new config
    // The "center" config is only used when calculating where
    // "center of the screen is" for "center-column" action.
    // Defaults to center of the screen
    center x=1536
}

For the positioning logic, it would have some simple clamping to make sure windows are not moved outside the monitor. Pseudo-code:

window.x = monitor.x + monitor.center.x / 2 + window.width / 2
if window.x - window.width < monitor.x {
  window.x = monitor.x + window.width
}

[YaLTeR]

Hm. I see the problem. I'm just thinking that it might complicate the layout code quite a bit. Especially once you set always-center, and then resize the window big enough that it touches one side of the screen before the other. Now it can no longer easily behave as always-center, which sounds quite painful to deal with..

[YaLTeR]

Doing something just for Mod+C though sounds easy since it's a one time operation

[applejag]

Personally I would be completely fine with just the Mod+C approach. I don't really need it for the "always center the focused window" feature.

When only having it for Mod+C though I guess it would be harder to have it behave on a per-monitor basis, as then the output config would feel kind of weird as it's only used for one of the "center features" but not the other.

Again, in my case that would be fine. So depends on if focusing on my use case specifically, or if we want to generalize.

But if we're talking about only allowing this in binds, then I guess you mean something like this?

binds {

    Mod+C { center-column "30%"; } // defaults to "50%"

}

[YaLTeR]

Yeah, something like that. Probably with a name, so center-column something="30%"