Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install sfeMovie sample application via CMake #50

Open
firefly2442 opened this issue Jun 22, 2014 · 7 comments
Open

Install sfeMovie sample application via CMake #50

firefly2442 opened this issue Jun 22, 2014 · 7 comments

Comments

@firefly2442
Copy link
Member

If BUILD_SFEMOVIE_SAMPLE is checked in CMake, this will build the sample application. This can be run from the build directory. However, it does not get installed to the CMAKE_INSTALL_PREFIX location.

What do you think about making it install it there?

@Ceylo
Copy link
Member

Ceylo commented Jun 22, 2014

The main question here is: is it worth it?

I agree selecting BUILD_SFEMOVIE_SAMPLE means the user wants that demo program. At least he wants to execute it, but does he want to have it installed for easier use?

@firefly2442
Copy link
Member Author

Yep. Just something to consider I guess. Up to you. :)

@Ceylo
Copy link
Member

Ceylo commented Jun 26, 2014

That'll depend on how many users want this feature :)

So to anyone interested outta here, come on and vote!

@bluekirby0
Copy link

Unless you plan to add features to the sample program itself that can rival VLC or ffplay I would say leave the sample program where it can be tested easily with a new build and leave it at that.

Samples are generally made to showcase what a library can do without stupendously cluttering up the code with superfluous "added value" features, though, so I'd just leave it like it is and add features to it only when said features are provided by sfeMovie itself.

@Ceylo
Copy link
Member

Ceylo commented Aug 24, 2014

Thanks for you feedback :) , this is also my opinion so for now it'll probably stay as it is.

@feliwir
Copy link
Contributor

feliwir commented Aug 24, 2014

it would be awesome if you'd add the streamselection/seeking once you have it done, so they can see how it works (which is the purpose of a sample i guess)

@Ceylo
Copy link
Member

Ceylo commented Aug 24, 2014

Yep this will most probably be done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants