-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install sfeMovie sample application via CMake #50
Comments
The main question here is: is it worth it? I agree selecting BUILD_SFEMOVIE_SAMPLE means the user wants that demo program. At least he wants to execute it, but does he want to have it installed for easier use? |
Yep. Just something to consider I guess. Up to you. :) |
That'll depend on how many users want this feature :) So to anyone interested outta here, come on and vote! |
Unless you plan to add features to the sample program itself that can rival VLC or ffplay I would say leave the sample program where it can be tested easily with a new build and leave it at that. Samples are generally made to showcase what a library can do without stupendously cluttering up the code with superfluous "added value" features, though, so I'd just leave it like it is and add features to it only when said features are provided by sfeMovie itself. |
Thanks for you feedback :) , this is also my opinion so for now it'll probably stay as it is. |
it would be awesome if you'd add the streamselection/seeking once you have it done, so they can see how it works (which is the purpose of a sample i guess) |
Yep this will most probably be done :) |
If
BUILD_SFEMOVIE_SAMPLE
is checked in CMake, this will build the sample application. This can be run from the build directory. However, it does not get installed to theCMAKE_INSTALL_PREFIX
location.What do you think about making it install it there?
The text was updated successfully, but these errors were encountered: