Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

24/7 command informing an incorrect status for 24/7 when toggled #1125

Open
2 tasks done
xayanide opened this issue Apr 12, 2024 · 2 comments · Fixed by #1128
Open
2 tasks done

24/7 command informing an incorrect status for 24/7 when toggled #1125

xayanide opened this issue Apr 12, 2024 · 2 comments · Fixed by #1128
Assignees
@xayanide
Labels
branch:next Issues: Impacts next branch branch:stable Issues: Impacts stable branch priority:p3 Issues and PRs: Low priority released on @next released status:confirmed Issues and PRs: Confirmed bug, or enhancement is confirmed to be added type:bug Issues and PRs: Related to a bug

Comments

@xayanide
Copy link
Member

xayanide commented Apr 12, 2024 •
edited
Loading

Describe the bug

Low priority, as it only affects the sent message. Only when toggling it always shows that it is disabled despite being enabled and vice-versa.

To toggle 247, the user has to use the slash command 247 without using any of its options that is the enabled option.
Functionality-wise it is okay. 24/7 works just fine by itself.

2024-04-12_01-11-774-PM_Capture
2024-04-12_01-11-417-PM_Capture

Severity

Low

Affected branches

  • Stable
  • Next

Quaver version

7.0.1

Steps to reproduce

  1. Start Quaver
  2. Join a voice or stage channel.
  3. Type and enter /247, use the command directly without using any option to toggle it.

Expected behavior

If enabled it should say it is enabled.
If disabled it should say it is disabled.

Actual behavior

Quaver always responds that it is disabled.

Relevant log output

No response
@xayanide xayanide added type:bug Issues and PRs: Related to a bug status:confirmed Issues and PRs: Confirmed bug, or enhancement is confirmed to be added branch:stable Issues: Impacts stable branch branch:next Issues: Impacts next branch labels Apr 12, 2024
@xayanide xayanide changed the title 24/7 command showing incorrect status when toggled. 24/7 command showing incorrect status when toggled Apr 12, 2024
@github-actions github-actions bot added the priority:p3 Issues and PRs: Low priority label Apr 12, 2024
@xayanide xayanide changed the title 24/7 command showing incorrect status when toggled 24/7 command informing an incorrect status when toggled Apr 12, 2024
@xayanide xayanide changed the title 24/7 command informing an incorrect status when toggled 24/7 command informing an 247 incorrect status when toggled Apr 12, 2024
@xayanide xayanide changed the title 24/7 command informing an 247 incorrect status when toggled 24/7 command informing an incorrect status for 247 when toggled Apr 12, 2024
@xayanide xayanide changed the title 24/7 command informing an incorrect status for 247 when toggled 24/7 command informing an incorrect status for 24/7 when toggled Apr 12, 2024
@github-actions github-actions bot removed the priority:p3 Issues and PRs: Low priority label Apr 12, 2024
@xayanide xayanide added the priority:p3 Issues and PRs: Low priority label Apr 12, 2024
@xayanide xayanide self-assigned this Apr 12, 2024
xayanide added a commit to xayanide/Quaver that referenced this issue Apr 12, 2024
@xayanide
fix(cmd-247): incorrect output on toggle
eda0c45 
Closes ZPTXDev#1125
@xayanide xayanide mentioned this issue Apr 12, 2024
Merged
15 tasks
@xayanide xayanide linked a pull request Apr 12, 2024 that will close this issue
fix(cmd-247): incorrect output on toggle #1128
Merged
15 tasks
@zptx-bot
Copy link
Member

zptx-bot commented Jul 1, 2024

🎉 This issue has been resolved in version 7.0.2-next.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@zptx-bot
Copy link
Member

zptx-bot commented Jul 1, 2024

🎉 This issue has been resolved in version 7.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xayanide xayanide

Labels
branch:next Issues: Impacts next branch branch:stable Issues: Impacts stable branch priority:p3 Issues and PRs: Low priority released on @next released status:confirmed Issues and PRs: Confirmed bug, or enhancement is confirmed to be added type:bug Issues and PRs: Related to a bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cmd-247): incorrect output on toggle xayanide/Quaver
2 participants
@xayanide @zptx-bot