Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in console if timed out mid-session #384

Open
1 of 4 tasks
xayanide opened this issue Jul 18, 2022 · 2 comments
Open
1 of 4 tasks

Error in console if timed out mid-session #384

xayanide opened this issue Jul 18, 2022 · 2 comments
Assignees
Labels
affects:permissions Issues and PRs: Affects Discord permissions priority:p3 Issues and PRs: Low priority status:confirmed Issues and PRs: Confirmed bug, or enhancement is confirmed to be added status:hold Issues and PRs: On hold, to be reviewed type:bug Issues and PRs: Related to a bug

Comments

@xayanide
Copy link
Member

xayanide commented Jul 18, 2022

Describe the bug
What isn't working as intended, and what does it affect?
Condition intermittently working, sometimes not at all.
The error is DiscordAPIError[50013]: Missing Permissions
I would like a more consistent solution.

Extension of issue #222

Severity

  • Critical
  • High
  • Medium
  • Low

Affected versions
What versions are affected by this bug? (e.g. >=3.0.1, 2.5.1-2.6.3, >=1.2.0)
> 3.4.0

> 7.0.1 (checked at 4/19/2024)

Steps to reproduce
Steps to reproduce the behavior. (e.g. click on a button, enter a value, etc. and see error)

  1. Play any track with Quaver in a voice or stage channel
  2. Manually time out Quaver

Expected behavior
What is expected to happen?
Show no error at all.

Actual behavior
What actually happens? Attach or add errors or screenshots here as well.

if (this.client.guilds.cache.get(this.player.guildId).members.me.isCommunicationDisabled()) return false;

^ Sometimes this condition becomes false and the message gets sent to the channel while Quaver is timed out (which Quaver cannot).
We need a more consistent solution.

$ node .
2022-07-18T08:36:42.713Z [Discord] INFO: Connected. Logged in as Aia#3990.
2022-07-18T08:36:42.719Z [Quaver] INFO: Running version 5.0.0-next.2. For help, see https://github.com/ZPTXDev/Quaver/issues.
2022-07-18T08:36:42.720Z [Quaver] WARN: You are running an unstable version of Quaver. Please report bugs using the link above, and note that f
eatures may change or be removed entirely prior to release.
2022-07-18T08:36:46.161Z [Lavalink] INFO: Connected.
2022-07-18T08:37:47.273Z [Quaver] INFO: [G 906471497231630336 | U 250934589621665793] Processing command play
2022-07-18T08:37:47.276Z [Quaver] INFO: [G 906471497231630336 | U 250934589621665793] Executing command play
2022-07-18T08:37:51.316Z [Quaver] INFO: [G 906471497231630336] Starting track
2022-07-18T08:38:27.005Z [Quaver] INFO: [G 906471497231630336] Cleaning up
2022-07-18T08:38:35.607Z [Quaver] INFO: [G 906471497231630336 | U 250934589621665793] Processing command play
2022-07-18T08:38:35.610Z [Quaver] INFO: [G 906471497231630336 | U 250934589621665793] Executing command play
2022-07-18T08:38:56.378Z [Quaver] INFO: [G 906471497231630336 | U 250934589621665793] Processing command play
2022-07-18T08:38:56.379Z [Quaver] INFO: [G 906471497231630336 | U 250934589621665793] Executing command play
2022-07-18T08:39:01.528Z [Quaver] INFO: [G 906471497231630336] Starting track
2022-07-18T08:39:15.894Z [Quaver] INFO: [G 906471497231630336] Cleaning up
2022-07-18T08:39:16.373Z [Quaver] ERROR: Missing Permissions
DiscordAPIError[50013]: Missing Permissions
    at SequentialHandler.runRequest (C:\Users\Ava\Documents\GitHub\Quaver\node_modules\discord.js\node_modules\@discordjs\rest\dist\index.js:74
8:15)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async SequentialHandler.queueRequest (C:\Users\Ava\Documents\GitHub\Quaver\node_modules\discord.js\node_modules\@discordjs\rest\dist\ind
ex.js:560:14)
    at async REST.request (C:\Users\Ava\Documents\GitHub\Quaver\node_modules\discord.js\node_modules\@discordjs\rest\dist\index.js:1000:22)
    at async StageInstanceManager.delete (C:\Users\Ava\Documents\GitHub\Quaver\node_modules\discord.js\src\managers\StageInstanceManager.js:150
:5)
    at async StageInstance.delete (C:\Users\Ava\Documents\GitHub\Quaver\node_modules\discord.js\src\structures\StageInstance.js:129:5)
    at async PlayerHandler.disconnect (C:\Users\Ava\Documents\GitHub\Quaver\classes\PlayerHandler.js:34:6)
    at async Object.execute (C:\Users\Ava\Documents\GitHub\Quaver\events\voiceStateUpdate.js:31:5)

trackStart.js might be affected as well.

@xayanide xayanide added the type:bug Issues and PRs: Related to a bug label Jul 18, 2022
@xayanide xayanide changed the title Quaver throws an error on console when it is manually timed out while playing in a voice or stage channel Quaver throws an error on console when manually timed out while playing in a voice or stage channel Jul 18, 2022
@github-actions github-actions bot added priority:p3 Issues and PRs: Low priority status:proposed Issues and PRs: Pending confirmation labels Jul 18, 2022
@xayanide xayanide added status:confirmed Issues and PRs: Confirmed bug, or enhancement is confirmed to be added and removed status:proposed Issues and PRs: Pending confirmation labels Jul 18, 2022
@xayanide xayanide self-assigned this Jul 18, 2022
@xayanide xayanide changed the title Quaver throws an error on console when manually timed out while playing in a voice or stage channel Quaver sometimes throws an error on console when manually timed out while playing in a voice or stage channel Jul 18, 2022
@zapteryx zapteryx changed the title Quaver sometimes throws an error on console when manually timed out while playing in a voice or stage channel Error in console when timed out while playing in a voice or stage channel Jul 19, 2022
@zapteryx zapteryx changed the title Error in console when timed out while playing in a voice or stage channel Error in console when timed out mid-session Jul 19, 2022
@zapteryx zapteryx changed the title Error in console when timed out mid-session Error in console if timed out mid-session Jul 19, 2022
@xayanide xayanide added the affects:permissions Issues and PRs: Affects Discord permissions label Jul 19, 2022
@zapteryx zapteryx added the status:hold Issues and PRs: On hold, to be reviewed label Nov 24, 2022
@xayanide xayanide removed the status:hold Issues and PRs: On hold, to be reviewed label Apr 18, 2024
@xayanide
Copy link
Member Author

#379
#357

And this issue, are indirectly fixed by a change as of Quaver version 7.0.1, no longer reproducible, will reopen if this occurs again.

@xayanide
Copy link
Member Author

After the 50th try, this still occurs, but rarely.

@xayanide xayanide reopened this Apr 18, 2024
@xayanide xayanide added the status:hold Issues and PRs: On hold, to be reviewed label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:permissions Issues and PRs: Affects Discord permissions priority:p3 Issues and PRs: Low priority status:confirmed Issues and PRs: Confirmed bug, or enhancement is confirmed to be added status:hold Issues and PRs: On hold, to be reviewed type:bug Issues and PRs: Related to a bug
Development

No branches or pull requests

2 participants