Exemption reason text should not be reused

[mbrandl87]

Hi there,

in case you have an invoice made up of a position taxed according to a margin / second hand goods scheme (§25A) with exemption reason text "VATEX-EU-F" and a standard tax position, the standard position also gets the exemption reason set because its stored in a variable defined outside the looping of trans.getZFItems() which is only set if product.getExemptionReasion is not null but it isn't unset if its null.

Its also used further down when the tax summaries are written, so only the last reason is used. That means if you mix kategory E and O items, one would have a "wrong" reason.

I don't know if thats a real problem - the kosit validator still accepts the invoice though a standard rated position has an exemption reason set but its confusing me nevertheless :D

As well, E and O items would end up in one vat rate summary as you map them by percentage. I don't know if the standard would allow it or if it would make sense to summarize by category instead of percent.

might be I'm just misunderstanding things heere but I thought it would be better to bring it to your attention just in case :)

Best
Martin