Importer returns standard ubl for CreditNote: Why not EStandard ubl_creditnote?

[melo0187]

Since UBL has entirely different types for Invoice and CreditNote it would facilitate further processing (e.g. with https://github.com/phax/ph-ubl) a lot if ZUGFeRDInvoiceImporter's method for returning the standard would return ubl for UBL Invoices and ubl_creditnote for UBL CreditNote.

The enum EStandard already contains the entry ubl_creditnote, which is why I was expecting to get this as return from getStandard() for CreditNote documents and not ubl.

mustangproject/library/src/main/java/org/mustangproject/ZUGFeRD/ZUGFeRDInvoiceImporter.java

Lines 991 to 992 in 9b846ff

	} else if (rootNode.equals("CreditNote")) {
	return EStandard.ubl;

[jstaerk]

i guess I just overlooked that instance, do the tests still run when corrected?

[melo0187]

i guess I just overlooked that instance, do the tests still run when corrected?

TL;DR: I believe they do.

In an attempt to provide a quick answer to the question I pulled the latest master to run the test.
First this required fixing compile errors in ZF2EdgeTest, because it claims to override getPaymentMeansCode and getPaymentMeansInformation, which do not exist.
Then I did actually see a test failure in testEEISI_300_cii_Import(org.mustangproject.ZUGFeRD.ZF2ImporterTest).
However, this test fails already on master as is.
Returning EStandard.ubl_creditnote for rootNode.equals("CreditNote") does not add any test failures.

So in conclusion I think it is safe to correct the returned EStandard for CreditNotes.

[melo0187]

@jstaerk any thoughts on the PR #665 ?