Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Noetic support? #155

Open
pabloinigoblasco opened this issue Feb 12, 2021 · 5 comments
Open

[feature] Noetic support? #155

pabloinigoblasco opened this issue Feb 12, 2021 · 5 comments

Comments

@pabloinigoblasco
Copy link

Hello.
Is this repo planned to be supported in noetic?

We are using it in our examples in the smacc project and we wanted to move to noetic. We tried to add this project as git submodule and it partially works, but not totally.

https://www.youtube.com/watch?v=FYeNzukdIz4

At the current moment what I did as a workaround is to add the repo as a submodule (forking with some minor changes to at least pass the compilation stage). However it does not work in runtime properly.

@erelson
Copy link
Collaborator

erelson commented Feb 12, 2021

Hi @pabloinigoblasco

Yep, we essentially have noetic support but haven't released it yet; still need to do more testing on my part, and have been busy the past month or so. You can check out a few open PRs on this repo and the fetch_robots repo, in particular, with what changes we've got. Note that for noetic, the branch names we're using are "ros1" instead of "noetic_devel".

I think the equivalent to your linked gist is here: https://github.com/fetchrobotics/fetch_ros/pull/153/files#diff-e121feaf915d1716869198c422dfb66a86b6dfe56f7ebfdb8597cc90b78a39f2R17

One spot my testing ability that is a bit weak is with Gazebo. Is that part of what your team are experimenting with?

I also haven't personally played with git submodules myself in the past, but feel free to let me know what's not working in that regards.

@pabloinigoblasco
Copy link
Author

pabloinigoblasco commented Feb 15, 2021

I will try that branch you say.

  • Yes, we work with gazebo and also the fetch_gazebo package. It was working for melodic but now demos do not work in noetic.

  • We are trying to make them work again adding the fetch dependencies as submodules (github ref). To work in noetic I started forking the melodic branch and introducing some minor changes and I also needed to add some other dependent subrepositories; simple_grasping and robot_controllers.

  • I was able to make the demo start in gazebo but the robot did not work, specifically the part of moveit.

I will now retry everything but starting from the ros1 branch.

Nonetheless I have to say that some things in that ros1 branch looks like won't work on my environment.
For example, in my system in ubuntu 20.04 looks like the default opencv version is 4.2 instead 3.2. I think, that my environment is correct (ref)

I see in your ros1 branch you still reference 3.2 so maybe that approach you have in that branch is incorrect for noetic ubuntu 20.04.

@erelson
Copy link
Collaborator

erelson commented Feb 21, 2021

I see in your ros1 branch you still reference 3.2 so maybe that approach you have in that branch is incorrect for noetic ubuntu 20.04.

You might be reading the diffs incorrectly? My link above indicates version is 4.2, same as you're seeing. Or alternately you're using the "current" ros1 branch, where as my link is to changes that are still in PR. The erelson/noetic_tweaks branch is currently the latest. Let me know how it goes, though!

(To be clear, I haven't tried the Gazebo demos, etc. in noetic myself yet)

@pabloinigoblasco
Copy link
Author

Hello.
Thanks for your help. We already have our three fetch demos working based on your erleson/noetic_tweeks pull request. We used the fetch_melodic gazebo version and looks to be working correctly. We have our own gazebo scenarios so we did not tested the gazebo package intensively.

In our examples we faced three minor issues that may not be related with your work and repositories.

  • the ground truth pluging of gazebo overflows /tf with repeated transforms (that breaks the new policy of tf2 where you cannot repeat transforms with same frame_id and stamp)

  • we needed to to some changes in our sdf scene configuration because of some changes on gazebo11 related with the automatic entity naming

  • There were also some changes on moveit that affected us (probably not to you), related of the usage of the move_joints functionality (now you cannot send a command to move all the joints of the robot, including head_pan, head_title and fingers if you have selected some specific move_group)

  • These are the modules we needed to add for noetic examples (maybe not all are related with fetch examples)

image

@erelson
Copy link
Collaborator

erelson commented Mar 28, 2021

Just a quick note: there are ros-testing debians for everything needed for a ros noetic robot now. I need to test the USB version of the customized 20.04 OS installer still...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants