Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown is not being picked up #101

Open
ShipsWithCannons opened this issue Sep 2, 2015 · 7 comments
Open

Markdown is not being picked up #101

ShipsWithCannons opened this issue Sep 2, 2015 · 7 comments

Comments

@ShipsWithCannons
Copy link

code review is being detected.
**code** review (and other constructions like that) is not.

Could support for such be added?

Thanks to Dan Pantry for spotting.

@punmechanic
Copy link

For posterity, this is my GH ;-)

@punmechanic
Copy link

Not sure how we detect it now, but this might solve at least bold/italics. Might want to add tokens for strikethroughs too

@Vogel612
Copy link
Contributor

Vogel612 commented Sep 2, 2015

@danpantry this only picks up that special markdown combination. It may be more feasible to just strip the markdown before analyzing, by dropping ---|([*_])+ from all comment bodies before running the fuzzy match

@punmechanic
Copy link

this only picks up that special markdown combination.
but this might solve at least bold/italics.

You're right, of course. I just wonder whether it would be better to strip markdown instead of just ignoring it using regex.

@Vogel612
Copy link
Contributor

Vogel612 commented Sep 2, 2015

I feel like I am repeating myself..

#84 (comment)

The better option to this might be stripping the comments of markdown before examining them, instead of building a comparably unreadable regex to match them with markdown

@Vogel612
Copy link
Contributor

Vogel612 commented Sep 2, 2015

Should be simple enough. A .replaceAll(/* insert above regex */, ""); before examining the comment body should be good to go. Add some clean test-cases. @Zomis do you know of any analyzers that check for markdown-specific stuff? If not it might be interesting to strip the markdown when parsing the API-Call

@Zomis
Copy link
Owner

Zomis commented Sep 2, 2015

Don't know of any analyzers that check for markdown-specific stuff. In the future though, I might want to take markdown into consideration when analyzing results from the API. I don't think that will ever happen for comments on posts though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants