From 9afb6bd6034238befde23db3f5dcddfb079b0521 Mon Sep 17 00:00:00 2001 From: Abadi Kurniawan Date: Wed, 11 Sep 2019 16:25:41 -0500 Subject: [PATCH] Cleanup. Add contribution. --- README.md | 16 +++++++++++++--- src/Css/Animation.elm | 1 - src/Js/Main.elm | 4 ---- 3 files changed, 13 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index dda00cc..b9ec077 100644 --- a/README.md +++ b/README.md @@ -2,7 +2,9 @@ This project is for exploring the idea of doing highly performant animation in Elm with a nice API. -It's presented at [Elm-Conf 2019](https://2019.elm-conf.com/speakers/abadi-kurniawan) +It's presented at [Elm-Conf 2019](https://2019.elm-conf.com/speakers/abadi-kurniawan) with the title: **Building Highly Performant Animations in Elm** + + ## Install all dependencies: ``` @@ -14,7 +16,6 @@ npm install npm run slide ``` and then go to http://localhost:2222 -source Source code: https://github.com/abadi199/elm-animation-exploration/tree/master/src/Slide @@ -44,4 +45,13 @@ Source code: https://github.com/abadi199/elm-animation-exploration/tree/master/s Source code: https://github.com/abadi199/elm-animation-exploration/tree/master/src/Css ### Web Animations API (including experimental library) -Source code: https://github.com/abadi199/elm-animation-exploration/tree/master/src/Js \ No newline at end of file +Source code: https://github.com/abadi199/elm-animation-exploration/tree/master/src/Js + +## Contribution +This is an experimental project, and doesn't support all types of animation yet. I'm interested to build and publish a more complete package, but I have a limited free time. + +If you think this is a good idea and you're interested in collaborating to make this library a published Elm package, reach out to me at: +- Elm Community Slack: @abadi199 +- Twitter: @abadikurniawan +- or open an issue here: https://github.com/abadi199/elm-animation-exploration/issues/new + diff --git a/src/Css/Animation.elm b/src/Css/Animation.elm index 1c9d796..94d230e 100644 --- a/src/Css/Animation.elm +++ b/src/Css/Animation.elm @@ -224,7 +224,6 @@ toAnimationStyle animation = ++ " " ++ Second.toString delayDuration ++ " forwards" - |> Debug.log "delay" Sequence animations -> hash animation ++ " " ++ Second.toString (getTotalDuration animations) ++ " forwards" diff --git a/src/Js/Main.elm b/src/Js/Main.elm index 7e910da..d80842e 100644 --- a/src/Js/Main.elm +++ b/src/Js/Main.elm @@ -120,10 +120,6 @@ updateReady : Msg -> Data -> ( Model, Cmd Msg ) updateReady msg data = case msg of AnimationFinish -> - let - _ = - Debug.log "AnimationFinish" "" - in ( Ready data, Cmd.none ) UserCheckShowShadowCheckBox checked ->