Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade-mycnf doesn't process !includedir #89

Open
abg opened this issue Aug 11, 2015 · 0 comments
Open

upgrade-mycnf doesn't process !includedir #89

abg opened this issue Aug 11, 2015 · 0 comments

Comments

@abg
Copy link
Owner

abg commented Aug 11, 2015

The logic exists to track !include/!includedir directives in dbsake.core.mysql.mycnf.parser but the front-end returns the first result and just stops without processing the remaining entries.

This seems to be a simple fix. However, this may break output when --patch is omitted as the current behavior is just to print the modified config on stdout. So that basically output potentially multiple parsed .cnf on stdout which isn't useful - at least with the current "concat" implementation. For now it is probably best to just abort with an error after the first entry if we're not in patch mode, but maybe something smarter can be done in the future (merging configs properly or outputting a tar archive or something along those lines).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant