From fb865bbb3d333b3688e14ec9e68d1ce3789711bc Mon Sep 17 00:00:00 2001
From: maldworth <m@maldworth.com>
Date: Thu, 21 Nov 2019 06:06:59 -0500
Subject: [PATCH] Update nuget packages and cake build

- update to latest nuget package references
- create snupkg for nuget.org symbols server
- add Microsoft.SourceLink.GitHub package to allow for github SourceLink
debugging
---
 build.cake                                       |  3 ---
 src/FileCache.Signed/FileCache.Signed.csproj     | 16 +++++++++++++---
 .../FileCache.UnitTests.csproj                   |  8 ++++----
 src/FileCache/FileCache.csproj                   | 16 +++++++++++++---
 4 files changed, 30 insertions(+), 13 deletions(-)

diff --git a/build.cake b/build.cake
index 7a1aea1..159152f 100644
--- a/build.cake
+++ b/build.cake
@@ -41,7 +41,6 @@ Task("Restore-NuGet-Packages")
         settings
             .WithTarget("Restore")
             .SetConfiguration(configuration)
-            .UseToolVersion(MSBuildToolVersion.VS2017)
             );
 });
 
@@ -54,7 +53,6 @@ Task("Build")
 		settings
             .WithTarget("Build")
             .SetConfiguration(configuration)
-            .UseToolVersion(MSBuildToolVersion.VS2017)
             );
 });
 
@@ -78,7 +76,6 @@ Task("Create-NuGet-Packages")
     var settings = new MSBuildSettings()
         .WithTarget("Pack")
         .SetConfiguration(configuration)
-        .UseToolVersion(MSBuildToolVersion.VS2017)
         .WithProperty("PackageOutputPath",artifactDirectory);
 
     // Pack the Sln (unit tests has the <IsPackable> to false)
diff --git a/src/FileCache.Signed/FileCache.Signed.csproj b/src/FileCache.Signed/FileCache.Signed.csproj
index fb1276a..3316508 100644
--- a/src/FileCache.Signed/FileCache.Signed.csproj
+++ b/src/FileCache.Signed/FileCache.Signed.csproj
@@ -3,8 +3,7 @@
     <TargetFrameworks>net40;net45;netstandard2.0</TargetFrameworks>
     <PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
     <PackageTags>cache objectcache System.Runtime.Caching.ObjectCache</PackageTags>
-    <PackageLicenseUrl>https://github.com/acarteas/FileCache/blob/master/LICENSE</PackageLicenseUrl>
-    <PackageProjectUrl>https://github.com/acarteas/FileCache</PackageProjectUrl>
+    <PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
     <Authors>Adam Carter</Authors>
     <Description>FileCache is a concrete implementation of the .NET System.Runtime.Caching.ObjectCache that uses the local filesystem as the target location.</Description>
     <Copyright>Copyright (c) 2012, 2013, 2017 Adam Carter (http://adam-carter.com)</Copyright>
@@ -14,6 +13,16 @@
     <UpdateVersionProperties>true</UpdateVersionProperties>
     <Version>0.0.0</Version>
     <GeneratePackageOnBuild>false</GeneratePackageOnBuild>
+
+    <DebugSymbols>True</DebugSymbols>
+    <DebugType>portable</DebugType>
+
+    <EmbedUntrackedSources>true</EmbedUntrackedSources>
+    <IncludeSymbols>true</IncludeSymbols>
+    <SymbolPackageFormat>snupkg</SymbolPackageFormat>
+
+    <!-- SourceLink Config, needs nuget package in each csproj Microsoft.SourceLink.GitHub in order to work -->
+    <PublishRepositoryUrl>true</PublishRepositoryUrl>
   </PropertyGroup>
   <ItemGroup>
     <Compile Include="..\FileCache\BasicFileCacheManager.cs" Link="BasicFileCacheManager.cs" />
@@ -29,7 +38,8 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="GitVersionTask" Version="4.0.0-beta*">
+    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0-*" PrivateAssets="All" />
+    <PackageReference Include="GitVersionTask" Version="5.1.2">
       <PrivateAssets>All</PrivateAssets>
     </PackageReference>
   </ItemGroup>
diff --git a/src/FileCache.UnitTests/FileCache.UnitTests.csproj b/src/FileCache.UnitTests/FileCache.UnitTests.csproj
index 7278d39..2743690 100644
--- a/src/FileCache.UnitTests/FileCache.UnitTests.csproj
+++ b/src/FileCache.UnitTests/FileCache.UnitTests.csproj
@@ -7,10 +7,10 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.7.2" />
-    <PackageReference Include="MSTest.TestAdapter" Version="1.3.1" />
-    <PackageReference Include="MSTest.TestFramework" Version="1.3.1" />
-    <PackageReference Include="FluentAssertions" Version="5.3.2" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.4.0" />
+    <PackageReference Include="MSTest.TestAdapter" Version="2.0.0" />
+    <PackageReference Include="MSTest.TestFramework" Version="2.0.0" />
+    <PackageReference Include="FluentAssertions" Version="5.9.0" />
     
   </ItemGroup>
 
diff --git a/src/FileCache/FileCache.csproj b/src/FileCache/FileCache.csproj
index ca45404..f184cee 100644
--- a/src/FileCache/FileCache.csproj
+++ b/src/FileCache/FileCache.csproj
@@ -3,8 +3,7 @@
     <TargetFrameworks>net40;net45;netstandard2.0</TargetFrameworks>
 	  <PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
     <PackageTags>cache objectcache System.Runtime.Caching.ObjectCache</PackageTags>
-    <PackageLicenseUrl>https://github.com/acarteas/FileCache/blob/master/LICENSE</PackageLicenseUrl>
-    <PackageProjectUrl>https://github.com/acarteas/FileCache</PackageProjectUrl>
+    <PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
     <Authors>Adam Carter</Authors>
     <Description>FileCache is a concrete implementation of the .NET System.Runtime.Caching.ObjectCache that uses the local filesystem as the target location.</Description>
     <Copyright>Copyright (c) 2012, 2013, 2017 Adam Carter (http://adam-carter.com)</Copyright>
@@ -13,13 +12,24 @@
     <Company>Adam Carter</Company>
     <RootNamespace>System.Runtime.Caching</RootNamespace>
     <GeneratePackageOnBuild>false</GeneratePackageOnBuild>
+
+    <DebugSymbols>True</DebugSymbols>
+    <DebugType>portable</DebugType>
+
+    <EmbedUntrackedSources>true</EmbedUntrackedSources>
+    <IncludeSymbols>true</IncludeSymbols>
+    <SymbolPackageFormat>snupkg</SymbolPackageFormat>
+
+    <!-- SourceLink Config, needs nuget package in each csproj Microsoft.SourceLink.GitHub in order to work -->
+    <PublishRepositoryUrl>true</PublishRepositoryUrl>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net40|AnyCPU'">
     <GenerateSerializationAssemblies>Auto</GenerateSerializationAssemblies>
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="GitVersionTask" Version="4.0.0-beta*">
+    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0-*" PrivateAssets="All" />
+    <PackageReference Include="GitVersionTask" Version="5.1.2">
       <PrivateAssets>All</PrivateAssets>
     </PackageReference>
   </ItemGroup>