Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BUILD_PATH env variable to customise naming of production folder #75

Open
lucafalasco opened this issue Nov 16, 2020 · 5 comments
Open

Comments

@lucafalasco
Copy link
Contributor

Would be nice to change the path of the production folder, in my use case we have to create different folders at build time for each different language.
Example:

build/
-- app.js
-- index.html
-- assets/
-- fr/
---- app.js
---- index.html
-- de/
---- app.js
---- index.html

BUILD_PATH=build/fr

path: path.resolve('./build'),

@lucafalasco
Copy link
Contributor Author

lucafalasco commented Nov 16, 2020

Also maybe this line should be reverted?

d432792#diff-9b7d14c4a3da62774803e2fe1499ba9cff536bfd18e4adf22a46b5e8012f4aa7L30-R29

It would work perfectly if reading the path from config.output.path

@marcofugaro
Copy link
Contributor

marcofugaro commented Nov 16, 2020

Oops didn't realize that was an issue, I'll put back the config.output.path thing.

@marcofugaro
Copy link
Contributor

Done.

@lucafalasco
Copy link
Contributor Author

lucafalasco commented Nov 16, 2020

@marcofugaro nice, although I'm going to reopen this for the main issue which is supporting a BUILD_PATH env variable ok?

@lucafalasco lucafalasco reopened this Nov 16, 2020
@marcofugaro
Copy link
Contributor

Sure, is setting it from the webpack.config.js not enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants