From 73e5c52581c60edfd26be9c900a7c83c1f1c6ddc Mon Sep 17 00:00:00 2001 From: Andrew Clemons Date: Thu, 12 Dec 2024 20:41:13 +0900 Subject: [PATCH] Remove const ptr declaration from fromjstring/tojstring functions. I thought I had resolved the warning here in 8078536, but it is still a warning when using `env` inside of these functions by passing them into say `GetObjectClass` etc. Removing `const` completely silences any warnings. Related to #41 --- src/native/org_gnu_readline_Readline.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/native/org_gnu_readline_Readline.c b/src/native/org_gnu_readline_Readline.c index 1a0c090..d9dfce4 100644 --- a/src/native/org_gnu_readline_Readline.c +++ b/src/native/org_gnu_readline_Readline.c @@ -307,8 +307,8 @@ static size_t bufLength = 0; static char* word_break_buffer = NULL; -static char* fromjstring(JNIEnv const *env, jstring value); -static jstring tojstring(JNIEnv const *env, const char* value); +static char* fromjstring(JNIEnv *env, jstring value); +static jstring tojstring(JNIEnv *env, const char* value); static int allocBuffer(size_t n); @@ -776,7 +776,7 @@ JNIEXPORT jstring JNICALL /* Convert jstring to c-string */ /* -------------------------------------------------------------------------- */ -char* fromjstring(JNIEnv const *env, jstring value) { +char* fromjstring(JNIEnv *env, jstring value) { const jclass jstringClass = (*env)->GetObjectClass(env, value); const jmethodID getBytesMethodId = (*env)->GetMethodID(env, jstringClass, "getBytes", "()[B"); @@ -822,7 +822,7 @@ char* fromjstring(JNIEnv const *env, jstring value) { /* Convert c-string to j-string */ /* -------------------------------------------------------------------------- */ -jstring tojstring(JNIEnv const *env, const char* value) { +jstring tojstring(JNIEnv *env, const char* value) { const jclass jstringClass = (*env)->FindClass(env,"java/lang/String"); const jmethodID constructorMethodId = (*env)->GetMethodID(env, jstringClass, "", "([B)V");