Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockerfiles to use volumes to manage source #42

Open
bcongdon opened this issue Aug 19, 2017 · 1 comment
Open

Update dockerfiles to use volumes to manage source #42

bcongdon opened this issue Aug 19, 2017 · 1 comment

Comments

@bcongdon
Copy link
Member

We can improve the dev experience on Groot by using Docker volumes instead of using ADD to include source in the docker image.

@bcongdon bcongdon added this to the Groot v1.0 milestone Aug 19, 2017
@bcongdon bcongdon self-assigned this Aug 19, 2017
@narendasan narendasan mentioned this issue Aug 20, 2017
21 tasks
@bcongdon bcongdon removed their assignment Aug 22, 2017
@bcongdon
Copy link
Member Author

Doing some more digging on this, I don't think we should change Dockerfiles. The idiomatic way of creating Dockerfiles is to bake the source in with the container image.

However, we can add a 'development' docker command to the docs, so that you can mount a service's source directory inside the container for development.

Something like:
docker run -v `pwd`:/usr/src/app <container_id>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant