Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inwx: Be case insensitive while searching for the cookie. #4764

Merged
merged 1 commit into from
Sep 2, 2023
Merged

inwx: Be case insensitive while searching for the cookie. #4764

merged 1 commit into from
Sep 2, 2023

Conversation

sebastianas
Copy link

At least since 2023-08-25 the cookie is set via set-cookie' instead the expecting Set-Cookie' string. A month earlier it was working.

Ignore the case while matching the cookie.

@github-actions
Copy link

Welcome
Please make sure you're read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨

@sebastianas
Copy link
Author

Welcome Please make sure you're read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨

This should work out.

@sebastianas sebastianas mentioned this pull request Aug 28, 2023
@spaetz
Copy link

spaetz commented Aug 28, 2023

Not tested yet, but thanks already. Not sure if it would help as I don't seem to be getting any Header back, just a HTtP/2. But I will try your patch in any case.

@inwx-developer
Copy link

We have tested the patch and it's working.

At least since 2023-08-25 the cookie is set via `set-cookie' instead the
expecting `Set-Cookie' string. A month earlier it was working.

Ignore the case while matching the cookie.

Fixes: #4763
Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
@haupas
Copy link

haupas commented Aug 29, 2023

👍 Strongly Support This Pull Request 👏

I'd like to express our strong support for this pull request. It addresses a critical bug that has been affecting our company and numerous customers, causing significant disruptions.

We've been awaiting a solution to this issue and have conducted thorough testing on this pull request. I'm pleased to confirm that it effectively resolves the problem. Given the substantial impact this bug has had, I believe that merging this pull request is of the utmost importance.

Additionally, I'd like to highlight that we have a dependency on the acme.sh software in several systems throughout our infrastructure. The process of updating these packages will take some additional time, and the sooner we can get this pull request merged, the sooner we can begin that process.

Thank you for considering our input, and we sincerely hope to see this pull request merged soon.

Best regards

@zeroservices
Copy link

+1

Would really appreciate this pull request being merged soon.

@bekanne
Copy link

bekanne commented Aug 30, 2023

Will fix this issue: #4763

@Neilpang Neilpang merged commit b788cc2 into acmesh-official:dev Sep 2, 2023
12 checks passed
@haupas
Copy link

haupas commented Sep 20, 2023

Thank's for merging the pull request into the dev branch.
When can we except this fix to appear in the main branch / inside a new release?
Currently we fixed the issue manually in some of our systems, where certitifcates would expire soon. But we would rather not like this to be necessary on all our systems, which use the acme client.

@Neilpang
Copy link
Member

It will be one week or 2.

@TheHellSite
Copy link

Hello @Neilpang ,

any news on the ETA for the release including the pull request?

@Neilpang
Copy link
Member

Neilpang commented Oct 6, 2023

here you go:
https://github.com/acmesh-official/acme.sh/releases/tag/3.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants