Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests that check zarr is written as expected #43

Open
nclack opened this issue Mar 23, 2023 · 1 comment
Open

add tests that check zarr is written as expected #43

nclack opened this issue Mar 23, 2023 · 1 comment
Labels

Comments

@nclack
Copy link
Member

nclack commented Mar 23, 2023

We write metadata to tiff and zarr but don't test what's written inside cpx. The approach to date has been to test on the cpx-python side where it's simpler to find and integrate standard reference reader implementations with the test code - for example, we can just pip install tifffile.

However it's better to catch these errors upstream if we can.

So this issue is really about finding candidate reference reader implementations and integrating them into our testing inside cpx.

There are a lot of possible approaches here, including using python.

for reference, see acquire-project/cpx#131

@nclack nclack changed the title add tests that check written files represent metadata as expected add tests that check zarr is written as expected Mar 27, 2023
@nclack
Copy link
Member Author

nclack commented Mar 27, 2023

On acquire-project/cpx#125 and acquire-project/cpx#135, I ran into a bunch of issues around how chunking was handled. There are probably a family of checks that would be nice to have:

  • zarray has the proper shape
  • expected number of chunks
  • chunk sizes are approximately correct
  • metadata checks described above

@aliddell aliddell transferred this issue from another repository Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

2 participants