Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale label does not get removed on PR #1197

Open
5 tasks
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Jan 8, 2025 · 8 comments
Open
5 tasks

Stale label does not get removed on PR #1197

efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Jan 8, 2025 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc

Description:
A clear and concise description of what the bug is.

Action version:
v9

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Repro steps:
Not sure how to repro but here is the workflow: https://github.com/FreeTubeApp/FreeTube/blob/development/.github/workflows/stale.yml
Bot mentioned PR is stale FreeTubeApp/FreeTube#5885 (comment)

PR clearly had activity after that but stale label didnt get removed

Expected behavior:
Label gets removed

Actual behavior:
Label didnt get removed

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Author

efb4f5ff-1298-471a-8973-3d47447115dc commented Jan 8, 2025

Maybe a duplicate of #1133 not sure? if so sorry about that

@HarithaVattikuti
Copy link
Contributor

Hello @efb4f5ff-1298-471a-8973-3d47447115dc 👋,
Thank you for reporting this issue. We will investigate it and get back to you as soon as we have some feedback.

@suyashgaonkar
Copy link

suyashgaonkar commented Jan 28, 2025

Hi @efb4f5ff-1298-471a-8973-3d47447115dc , we investigated the issue from the provided details and we see that there is no problem with workflow or with actions/stale as it is able to remove the stale labels for the issues. You can refer to the following workflow run and the PR as an example for more clarity.

@efb4f5ff-1298-471a-8973-3d47447115dc

The issue labels and PR labels are different. They didnt change since the introduction of the workflow. If it is working correctly why aren't the labels being removed from PR's

@suyashgaonkar
Copy link

Hi @efb4f5ff-1298-471a-8973-3d47447115dc, Apologies for the confusion caused by the previous comment. We investigated and tested the provided workflow on our end, and it successfully removed the stale labels from the PRs as expected.You can refer to the following workflow run and the PR as an example for more clarity.

@efb4f5ff-1298-471a-8973-3d47447115dc

Hmm interesting, the workflow indeed runs fine at your end. Any idea why it doesnt remove the label in our repo?

@suyashgaonkar
Copy link

suyashgaonkar commented Feb 7, 2025

Hi @efb4f5ff-1298-471a-8973-3d47447115dc , we went through the runs of previous month for shared workflow file. We see that mentioned PR was skipped in the runs between 4th Jan to 13th Jan, the reason being the statefulness feature or the way caching works in actions/stale. The mentioned PR was picked up next on the 14th Jan run after the 3rd Jan’s run where it was not in stale state hence no labels were modified during these runs(4th Jan -13th Jan) in between. We recommend you to go through the following link to get more insights on the actions/stale statefulness and pass an operations-per-run value in the workflow as per your requirement to handle the caching. Kindly check the following screenshots for more information. Screenshots has information on the runs on 3rd Jan, 13th Jan (similar from 4th - 13th Jan), 14th Jan

Screenshot for workflow run on 3rd Jan:

Image

Screenshot for workflow run for 13th Jan (Same is the case for 4th-13th Jan):

Image

Screenshot for workflow run on 14th Jan:

Image

@suyashgaonkar
Copy link

Hi @efb4f5ff-1298-471a-8973-3d47447115dc , We are awaiting for your response, you can let us know if you still have any queriers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants