-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some queries DoS the backend, frontend hangs #673
Comments
@tuukka @nicolaes Thanks a lot for pointing this out to us! I looked at the query, and it's a combination of three problems:
|
Thank you for the quick reply and help! Re 1: Could you additionally configure the backend service so that it automatically restarts after a crash? Re 2: Here's another one of the queries that crashed - is it the same issue or something else causing the crash here? https://qlever.cs.uni-freiburg.de/wikidata/uBQWSn Re 3: If I recall correctly, the server replied to the query with a 404 error. Perhaps the frontend code couldn't handle that? |
@tuukka @nicolaes Here is a quick update @ Romanian query: The problem QLever had with that query ran a bit deeper and we are still working on that. But what's probably more interesting for you is that your original query did not make sense because it gives an empty result because a Wikidata entity can have a subset of the many properties in the query, but never all of them. A more meaningful variant of the query is the following: https://qlever.cs.uni-freiburg.de/wikidata/m76Lrg . This takes 23 seconds on QLever. It's not super fast, but it's also a very hard query (and Blazegraph or Virtuoso both time out on it). @ English variant of the query: You can just replace the two @ QLever UI: The QLever UI failed to show a proper error message when the backend did not reply (it did not matter what the status code was). This is now fixed and the UI should report a meaningful message in all cases. Please let us know if there are any more problems. |
Is this a typo in the code?
|
For which query (on which instance) did you get this result? |
This was last night, approximately an hour before midnight UTC. Unfortunately I didn't save more details. |
First step: Reload https://qlever.cs.uni-freiburg.de (F12 to open the Developer Console, Network -> Disable Cache, F5). Let us know when you encounter the error again. |
@hannahbast thank you for looking into this 🙏 |
Some of our queries seem to crash the backend, which results in a denial-of-service for all users. Also, in this case the frontend looks like the query is still executing (the spinner keeps turning).
Here's links to some of our problematic queries: tom-james-watson/wikitrivia#26
The text was updated successfully, but these errors were encountered: