New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve `set_port` validation and `get_host` behavior #829

Closed

mertcanaltin wants to merge 7 commits into ada-url:main from mertcanaltin:mert/fix-set-port-validation

Contributor

mertcanaltin commented Jan 5, 2025

fix Ensure set_port correctly handles invalid port values


          fix: Improve set_port validation and get_host behavior

b05d75e

anonrig requested a review from lemire

January 5, 2025 22:25

anonrig reviewed

View reviewed changes

src/url_aggregator.cpp Show resolved Hide resolved

tests/basic_tests.cpp Outdated Show resolved Hide resolved

anonrig reviewed

View reviewed changes

tests/basic_tests.cpp Outdated Show resolved Hide resolved

mertcanaltin and others added 2 commits

January 6, 2025 01:31


          Update tests/basic_tests.cpp

f5a2e1a

Co-authored-by: Yagiz Nizipli <[email protected]>


          add validation for ada_set_port to reject invalid port values

f738817

anonrig reviewed

View reviewed changes

src/ada_c.cpp Outdated Show resolved Hide resolved

anonrig reviewed

View reviewed changes

tests/basic_tests.cpp Show resolved Hide resolved


          Update tests/basic_tests.cpp

51d283c

Co-authored-by: Yagiz Nizipli <[email protected]>

anonrig reviewed

View reviewed changes

tests/basic_tests.cpp Outdated Show resolved Hide resolved

mertcanaltin and others added 3 commits

January 6, 2025 01:57


          Update tests/basic_tests.cpp

43aa8c6

Co-authored-by: Yagiz Nizipli <[email protected]>


          revert changes in c api

8574c1f


          centralize port validation logic into parse_port

9a6637e

mertcanaltin closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet