From 2c34eec85e30752e5d273c1bf5e8c752301ab737 Mon Sep 17 00:00:00 2001 From: Yagiz Nizipli Date: Thu, 30 Jan 2025 15:24:05 -0500 Subject: [PATCH 1/2] add more macos versions to test --- .github/workflows/macos_install.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/macos_install.yml b/.github/workflows/macos_install.yml index fa948c1cb..a5f848043 100644 --- a/.github/workflows/macos_install.yml +++ b/.github/workflows/macos_install.yml @@ -1,4 +1,4 @@ -name: macos (Installation) +name: macOS (Installation) on: pull_request: @@ -22,11 +22,11 @@ concurrency: jobs: macos-build: - runs-on: macos-15 strategy: matrix: - include: - - shared: OFF + shared: [OFF] + runs-on: [macos-13, macos-14, macos-15] + runs-on: ${{matrix.runs-on}} steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 - name: Prepare From 1402143e3204855477621e8ea25e2c3d1d3c9c73 Mon Sep 17 00:00:00 2001 From: Daniel Lemire Date: Thu, 30 Jan 2025 16:29:40 -0500 Subject: [PATCH 2/2] trying something --- include/ada/url_pattern.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/ada/url_pattern.h b/include/ada/url_pattern.h index 90091b958..0417a9dd7 100644 --- a/include/ada/url_pattern.h +++ b/include/ada/url_pattern.h @@ -284,11 +284,9 @@ class url_pattern { } #endif // ADA_TESTING - template - friend tl::expected, errors> parser::parse_url_pattern_impl( + friend tl::expected, errors> parser::parse_url_pattern_impl( std::variant input, const std::string_view* base_url, const url_pattern_options* options); - private: url_pattern_component protocol_component{}; url_pattern_component username_component{};