From 15066606ef69c6f4699f08c1cbde53993578e8eb Mon Sep 17 00:00:00 2001 From: dskkato Date: Fri, 9 Aug 2024 22:59:32 +0900 Subject: [PATCH 01/13] update ci --- .github/workflows/ci.yml | 2 +- .github/workflows/requirements.txt | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2d1808b393..79232d29b5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -31,7 +31,7 @@ jobs: - name: Setup Python # Set Python version uses: actions/setup-python@v4 with: - python-version: 3.8 + python-version: 3.10 # Install pip and pytest - name: Install dependencies run: | diff --git a/.github/workflows/requirements.txt b/.github/workflows/requirements.txt index 0d17710148..c5dcbbbb99 100644 --- a/.github/workflows/requirements.txt +++ b/.github/workflows/requirements.txt @@ -1 +1,2 @@ tensorflow == 2.17.0 +tf_keras == 2.17.0 \ No newline at end of file From 2a8a784eeacbbf1f1840dfd9349302b7121dbe22 Mon Sep 17 00:00:00 2001 From: dskkato Date: Fri, 9 Aug 2024 23:01:13 +0900 Subject: [PATCH 02/13] update ci --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 79232d29b5..1454f14329 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -31,7 +31,7 @@ jobs: - name: Setup Python # Set Python version uses: actions/setup-python@v4 with: - python-version: 3.10 + python-version: '3.10' # Install pip and pytest - name: Install dependencies run: | From 7ab00c923c8e41299bd2d3afd8ed9d0e5d36a97b Mon Sep 17 00:00:00 2001 From: dskkato Date: Fri, 9 Aug 2024 23:22:28 +0900 Subject: [PATCH 03/13] update ci --- .github/workflows/ci.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1454f14329..28a2f413e5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,11 +22,9 @@ jobs: - windows-latest steps: - uses: actions/checkout@v2 - - uses: actions-rs/toolchain@v1 + - uses: dtolnay/rust-toolchain@stable with: - profile: minimal toolchain: stable - override: true components: rustfmt - name: Setup Python # Set Python version uses: actions/setup-python@v4 From 751610f6f411b5420a366d14cedcafb1b1dc129f Mon Sep 17 00:00:00 2001 From: dskkato Date: Sat, 17 Aug 2024 22:46:55 +0900 Subject: [PATCH 04/13] split test cases --- .github/workflows/ci.yml | 37 ++++---- test-all | 179 +++++++++++++++++++++++---------------- 2 files changed, 128 insertions(+), 88 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 28a2f413e5..7f74068802 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -35,21 +35,24 @@ jobs: run: | python -m pip install --upgrade pip pip install -r .github/workflows/requirements.txt - - name: Execute test-all - run: ./test-all + - name: Execute version check + run: ./test-all version-check + shell: bash + - name: Execute clippy check + run: ./test-all clippy-cmd + shell: bash + - name: Execute fmt check + run: ./test-all fmt-cmd + shell: bash + - name: Execute test check + run: ./test-all test-cmd + shell: bash + - name: Execute example check + run: ./test-all example-cmd + shell: bash + - name: Execute doc check + run: ./test-all doc-cmd + shell: bash + - name: Execute attributes check + run: ./test-all attributes-check shell: bash -# clippy: -# runs-on: ubuntu-latest -# strategy: -# matrix: -# rust: -# - beta -# steps: -# - uses: actions/checkout@v2 -# - uses: actions-rs/toolchain@v1 -# with: -# profile: minimal -# toolchain: ${{ matrix.rust }} -# override: true -# components: clippy -# - run: cargo clippy \ No newline at end of file diff --git a/test-all b/test-all index ada9c9e29f..5df19b52be 100755 --- a/test-all +++ b/test-all @@ -9,79 +9,116 @@ function run { echo } -# Make sure the Tensorflow version in the -sys build script matches the one in -# the run-valgrind script. -version_build_script=`grep "const VERSION" tensorflow-sys/build.rs | sed 's|.*"\([^"]*\)";|\1|g'` -version_requirements=`grep "tensorflow\s*=" .github/workflows/requirements.txt | sed "s|.*== \(.*\)|\1|g"` -if [[ "${version_build_script}" != "${version_requirements}" ]]; then - echo "ERROR: TensorFlow version specified in build script does not match the one in the" - echo " GitHub requirements." - echo " tensorflow-sys/build.rs: ${version_build_script}" - echo " .github/workflows/requirements.txt: ${version_requirements}" - exit 1 -fi - -# Make sure the crate version matches the one in README.md. -version_tensorflow_crate=`grep "^version =" Cargo.toml | sed 's|.*= "\(.*\)"|\1|g'` -version_tensorflow_readme=`sed -En 's|tensorflow *= *"([^"]*)"|\1|p' < README.md` -version_tensorflow_readme2=`sed -En 's|tensorflow *= *\{ *version *= *"([^"]*)".*$|\1|p' < README.md` -if [[ "${version_tensorflow_crate}" != "${version_tensorflow_readme}" || \ - "${version_tensorflow_crate}" != "${version_tensorflow_readme2}" ]]; then - echo "ERROR: tensorflow crate version does not match the ones in README.md." - echo " Cargo.toml: ${version_tensorflow_crate}" - echo " README.md: ${version_tensorflow_readme}" - echo " README.md: ${version_tensorflow_readme2}" - exit 1 -fi - -# Make sure the crate version matches the one in README.md for tensorflow-sys. -version_tensorflow_sys_crate=`grep "^version =" tensorflow-sys/Cargo.toml | sed 's|.*= "\(.*\)"|\1|g'` -version_tensorflow_sys_readme=`sed -En 's|tensorflow-sys *= *\{ *version *= *"([^"]*)".*$|\1|p' < tensorflow-sys/README.md` -if [[ "${version_tensorflow_sys_crate}" != "${version_tensorflow_sys_readme}" ]]; then - echo "ERROR: tensorflow-sys crate version does not match the one in README.md." - echo " Cargo.toml: ${version_tensorflow_sys_crate}" - echo " README.md: ${version_tensorflow_sys_readme}" - exit 1 -fi - -# Legacy Keras required for now because Keras 3 requires exporting models as -# Keras format, which the C API can't read: -# https://github.com/tensorflow/tensorflow/issues/70514 -TF_USE_LEGACY_KERAS=1 run python3 examples/mobilenetv3/create_model.py -# TODO(#391): Re-enable: (cd test_resources/library && ./build-test-op) -run cargo fmt --all -- --check -run cargo test -vv -j 2 -run cargo test -vv -j 2 --features eager -run cargo test -vv -j 2 --features tensorflow_unstable -run cargo test -vv -j 2 --features ndarray -run cargo run --example regression -run cargo run --example xor -run cargo run --features tensorflow_unstable --example expressions -run cargo run --features eager --example mobilenetv3 -run cargo doc -vv --features experimental,tensorflow_unstable,ndarray,eager -run cargo doc -vv --features experimental,tensorflow_unstable,ndarray,eager,private-docs-rs -# TODO(#66): Re-enable: (cd tensorflow-sys && cargo test -vv -j 1) -(cd tensorflow-sys && run cargo run --example multiplication) -(cd tensorflow-sys && run cargo run --example tf_version) -(cd tensorflow-sys && run cargo doc -vv) - -run cargo clippy -(cd tensorflow-sys && run cargo clippy) -(cd tensorflow-op-codegen && run cargo clippy) -(cd tensorflow-proto-codegen && run cargo clippy) -(cd tensorflow-internal-macros && run cargo clippy) +function version-check { + echo "Checking versions..." + # Make sure the Tensorflow version in the -sys build script matches the one in + # the run-valgrind script. + version_build_script=`grep "const VERSION" tensorflow-sys/build.rs | sed 's|.*"\([^"]*\)";|\1|g'` + version_requirements=`grep "tensorflow\s*=" .github/workflows/requirements.txt | sed "s|.*== \(.*\)|\1|g"` + if [[ "${version_build_script}" != "${version_requirements}" ]]; then + echo "ERROR: TensorFlow version specified in build script does not match the one in the" + echo " GitHub requirements." + echo " tensorflow-sys/build.rs: ${version_build_script}" + echo " .github/workflows/requirements.txt: ${version_requirements}" + exit 1 + fi -for file in $(find . -name target -prune -o -name '*.rs' -print); do - bad_deprecations="$(rustfmt --emit stdout --config max_width=1000 "$file" | grep '#\[deprecated' | grep -E -v '([^"\\]|\\.|"([^"\\]|\\.)*")*since' || true)" - if [[ "${bad_deprecations}" != "" ]]; then - echo "ERROR: #[deprecated] attribute(s) found with no 'since' key in $file:" - echo "${bad_deprecations}" + # Make sure the crate version matches the one in README.md. + version_tensorflow_crate=`grep "^version =" Cargo.toml | sed 's|.*= "\(.*\)"|\1|g'` + version_tensorflow_readme=`sed -En 's|tensorflow *= *"([^"]*)"|\1|p' < README.md` + version_tensorflow_readme2=`sed -En 's|tensorflow *= *\{ *version *= *"([^"]*)".*$|\1|p' < README.md` + if [[ "${version_tensorflow_crate}" != "${version_tensorflow_readme}" || \ + "${version_tensorflow_crate}" != "${version_tensorflow_readme2}" ]]; then + echo "ERROR: tensorflow crate version does not match the ones in README.md." + echo " Cargo.toml: ${version_tensorflow_crate}" + echo " README.md: ${version_tensorflow_readme}" + echo " README.md: ${version_tensorflow_readme2}" exit 1 fi - bad_deprecations="$(rustfmt --emit stdout --config max_width=1000 "$file" | grep '#\[deprecated' | grep -E -v '([^"\\]|\\.|"([^"\\]|\\.)*")*note' || true)" - if [[ "${bad_deprecations}" != "" ]]; then - echo "ERROR: #[deprecated] attribute(s) found with no 'note' key in $file:" - echo "${bad_deprecations}" + + # Make sure the crate version matches the one in README.md for tensorflow-sys. + version_tensorflow_sys_crate=`grep "^version =" tensorflow-sys/Cargo.toml | sed 's|.*= "\(.*\)"|\1|g'` + version_tensorflow_sys_readme=`sed -En 's|tensorflow-sys *= *\{ *version *= *"([^"]*)".*$|\1|p' < tensorflow-sys/README.md` + if [[ "${version_tensorflow_sys_crate}" != "${version_tensorflow_sys_readme}" ]]; then + echo "ERROR: tensorflow-sys crate version does not match the one in README.md." + echo " Cargo.toml: ${version_tensorflow_sys_crate}" + echo " README.md: ${version_tensorflow_sys_readme}" exit 1 fi -done +} + +function clippy-cmd { + echo "Running clippy..." + run cargo clippy + (cd tensorflow-sys && run cargo clippy) + (cd tensorflow-op-codegen && run cargo clippy) + (cd tensorflow-proto-codegen && run cargo clippy) + (cd tensorflow-internal-macros && run cargo clippy) +} + +function fmt-cmd { + echo "Running cargo fmt..." + run cargo fmt --all -- --check +} + +function test-cmd { + echo "Running tests..." + run cargo test -vv -j 2 + run cargo test -vv -j 2 --features eager + run cargo test -vv -j 2 --features tensorflow_unstable + run cargo test -vv -j 2 --features ndarray + # TODO(#66): Re-enable: (cd tensorflow-sys && cargo test -vv -j 1) +} + +function example-cmd { + echo "Running examples..." + # Legacy Keras required for now because Keras 3 requires exporting models as + # Keras format, which the C API can't read: + # https://github.com/tensorflow/tensorflow/issues/70514 + TF_USE_LEGACY_KERAS=1 run python3 examples/mobilenetv3/create_model.py + # TODO(#391): Re-enable: (cd test_resources/library && ./build-test-op) + run cargo run --example regression + run cargo run --example xor + run cargo run --features tensorflow_unstable --example expressions + run cargo run --features eager --example mobilenetv3 + (cd tensorflow-sys && run cargo run --example multiplication) + (cd tensorflow-sys && run cargo run --example tf_version) +} + +function doc-cmd { + echo "Building docs..." + run cargo doc -vv --features experimental,tensorflow_unstable,ndarray,eager + run cargo doc -vv --features experimental,tensorflow_unstable,ndarray,eager,private-docs-rs + (cd tensorflow-sys && run cargo doc -vv) +} + +function attributes-check { + echo "Checking #[deprecated] attributes..." + for file in $(find . -name target -prune -o -name '*.rs' -print); do + bad_deprecations="$(rustfmt --emit stdout --config max_width=1000 "$file" | grep '#\[deprecated' | grep -E -v '([^"\\]|\\.|"([^"\\]|\\.)*")*since' || true)" + if [[ "${bad_deprecations}" != "" ]]; then + echo "ERROR: #[deprecated] attribute(s) found with no 'since' key in $file:" + echo "${bad_deprecations}" + exit 1 + fi + bad_deprecations="$(rustfmt --emit stdout --config max_width=1000 "$file" | grep '#\[deprecated' | grep -E -v '([^"\\]|\\.|"([^"\\]|\\.)*")*note' || true)" + if [[ "${bad_deprecations}" != "" ]]; then + echo "ERROR: #[deprecated] attribute(s) found with no 'note' key in $file:" + echo "${bad_deprecations}" + exit 1 + fi + done +} + +# check command line arguments and run the appropriate commands +if [[ $# -eq 0 ]]; then + version-check + clippy-cmd + fmt-cmd + test-cmd + example-cmd + doc-cmd + attributes-check +else + run "$@" +fi From 1e71cc7e2fba21d22d129c8be4f8ea8138a54999 Mon Sep 17 00:00:00 2001 From: Daisuke Kato Date: Sat, 17 Aug 2024 23:01:10 +0900 Subject: [PATCH 05/13] use ubuntu only in ci. --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7f74068802..48850a5d33 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,8 +18,8 @@ jobs: matrix: os: - ubuntu-latest - - macos-latest - - windows-latest + # - macos-latest + # - windows-latest steps: - uses: actions/checkout@v2 - uses: dtolnay/rust-toolchain@stable From 253845ff80b505c9b8baf0c224a5e4d8340534bc Mon Sep 17 00:00:00 2001 From: Daisuke Kato Date: Sun, 18 Aug 2024 06:25:58 +0900 Subject: [PATCH 06/13] skit doc cmd test --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 48850a5d33..6595db9bb5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -50,9 +50,9 @@ jobs: - name: Execute example check run: ./test-all example-cmd shell: bash - - name: Execute doc check - run: ./test-all doc-cmd - shell: bash + # - name: Execute doc check + # run: ./test-all doc-cmd + # shell: bash - name: Execute attributes check run: ./test-all attributes-check shell: bash From 7b2a31de031351540db0659e6828fa83441916ce Mon Sep 17 00:00:00 2001 From: dskkato Date: Sun, 18 Aug 2024 07:38:33 +0900 Subject: [PATCH 07/13] update comments --- .github/workflows/ci.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6595db9bb5..45274ae72b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,13 +18,16 @@ jobs: matrix: os: - ubuntu-latest + # TODO(someone): re-enable the following platforms # - macos-latest # - windows-latest steps: - uses: actions/checkout@v2 - - uses: dtolnay/rust-toolchain@stable + - uses: actions-rs/toolchain@v1 with: + profile: minimal toolchain: stable + override: true components: rustfmt - name: Setup Python # Set Python version uses: actions/setup-python@v4 @@ -50,6 +53,7 @@ jobs: - name: Execute example check run: ./test-all example-cmd shell: bash + # TODO(someone): re-enable the following checks. In local, it works fine. # - name: Execute doc check # run: ./test-all doc-cmd # shell: bash From c19957e2b71c4654db11cf79d9ef89001e35bfe6 Mon Sep 17 00:00:00 2001 From: dskkato Date: Tue, 20 Aug 2024 22:02:08 +0900 Subject: [PATCH 08/13] Refactored test commands not to display verbose output --- test-all | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/test-all b/test-all index 5df19b52be..cde2865ee5 100755 --- a/test-all +++ b/test-all @@ -63,11 +63,11 @@ function fmt-cmd { function test-cmd { echo "Running tests..." - run cargo test -vv -j 2 - run cargo test -vv -j 2 --features eager - run cargo test -vv -j 2 --features tensorflow_unstable - run cargo test -vv -j 2 --features ndarray - # TODO(#66): Re-enable: (cd tensorflow-sys && cargo test -vv -j 1) + run cargo test -j 2 + run cargo test -j 2 --features eager + run cargo test -j 2 --features tensorflow_unstable + run cargo test -j 2 --features ndarray + # TODO(#66): Re-enable: (cd tensorflow-sys && cargo test -j 1) } function example-cmd { @@ -87,9 +87,9 @@ function example-cmd { function doc-cmd { echo "Building docs..." - run cargo doc -vv --features experimental,tensorflow_unstable,ndarray,eager - run cargo doc -vv --features experimental,tensorflow_unstable,ndarray,eager,private-docs-rs - (cd tensorflow-sys && run cargo doc -vv) + run cargo doc --features experimental,tensorflow_unstable,ndarray,eager + run cargo doc --features experimental,tensorflow_unstable,ndarray,eager,private-docs-rs + (cd tensorflow-sys && run cargo doc) } function attributes-check { From 34d4577d07cf49f223de871248a52512ffb09ca9 Mon Sep 17 00:00:00 2001 From: dskkato Date: Tue, 20 Aug 2024 22:04:39 +0900 Subject: [PATCH 09/13] update platforms --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6bf2421c46..6b152c7771 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,9 +18,9 @@ jobs: matrix: os: - ubuntu-latest - # TODO(someone): re-enable the following platforms + # TODO(someone): re-enable the macOS platform # - macos-latest - # - windows-latest + - windows-latest steps: - uses: actions/checkout@v2 - uses: actions-rs/toolchain@v1 From edba8edca75a34dbf697857d79376130a4c6327c Mon Sep 17 00:00:00 2001 From: dskkato Date: Tue, 20 Aug 2024 22:12:16 +0900 Subject: [PATCH 10/13] Revert "update platforms" This reverts commit 34d4577d07cf49f223de871248a52512ffb09ca9. --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6b152c7771..6bf2421c46 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,9 +18,9 @@ jobs: matrix: os: - ubuntu-latest - # TODO(someone): re-enable the macOS platform + # TODO(someone): re-enable the following platforms # - macos-latest - - windows-latest + # - windows-latest steps: - uses: actions/checkout@v2 - uses: actions-rs/toolchain@v1 From a99a55954cf97b6898578ca1e85bf52b35a76efd Mon Sep 17 00:00:00 2001 From: dskkato Date: Tue, 20 Aug 2024 22:17:40 +0900 Subject: [PATCH 11/13] re-enable doc tests --- .github/workflows/ci.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6bf2421c46..b27abcee6a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -53,10 +53,9 @@ jobs: - name: Execute example check run: ./test-all example-cmd shell: bash - # TODO(someone): re-enable the following checks. In local, it works fine. - # - name: Execute doc check - # run: ./test-all doc-cmd - # shell: bash + - name: Execute doc check + run: ./test-all doc-cmd + shell: bash - name: Execute attributes check run: ./test-all attributes-check shell: bash From 93926a1d9db5654202aa7dbc28ac6fb6d2109917 Mon Sep 17 00:00:00 2001 From: dskkato Date: Tue, 20 Aug 2024 23:05:02 +0900 Subject: [PATCH 12/13] refactored ci.yml --- .github/workflows/ci.yml | 60 +++++++++++++++++++++++++++++++--------- 1 file changed, 47 insertions(+), 13 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b27abcee6a..daba87fa8a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,7 +12,7 @@ env: # RUSTFLAGS: "-D warnings" # it needs some works to enable this flag jobs: - tests: + pre-compile-check: runs-on: ${{ matrix.os }} strategy: matrix: @@ -29,15 +29,6 @@ jobs: toolchain: stable override: true components: rustfmt - - name: Setup Python # Set Python version - uses: actions/setup-python@v4 - with: - python-version: "3.10" - # Install pip and pytest - - name: Install dependencies - run: | - python -m pip install --upgrade pip - pip install -r .github/workflows/requirements.txt - name: Execute version check run: ./test-all version-check shell: bash @@ -47,15 +38,58 @@ jobs: - name: Execute fmt check run: ./test-all fmt-cmd shell: bash + - name: Setup Python # Set Python version + uses: actions/setup-python@v4 + with: + python-version: "3.10" + tests: + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: + - ubuntu-latest + # TODO(someone): re-enable the following platforms + # - macos-latest + # - windows-latest + steps: + - uses: actions/checkout@v2 + - uses: actions-rs/toolchain@v1 + with: + profile: minimal + toolchain: stable + override: true + components: rustfmt - name: Execute test check run: ./test-all test-cmd shell: bash - - name: Execute example check - run: ./test-all example-cmd - shell: bash - name: Execute doc check run: ./test-all doc-cmd shell: bash - name: Execute attributes check run: ./test-all attributes-check shell: bash + examples: + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: + - ubuntu-latest + # TODO(someone): re-enable the following platforms + # - macos-latest + # - windows-latest + steps: + - uses: actions/checkout@v2 + - uses: actions-rs/toolchain@v1 + with: + profile: minimal + toolchain: stable + override: true + components: rustfmt + # Install pip and pytest + - name: Install dependencies + run: | + python -m pip install --upgrade pip + pip install -r .github/workflows/requirements.txt + - name: Execute example check + run: ./test-all example-cmd + shell: bash From bb7a33fdda3634b4edf2f55b4060e025dc2dacf8 Mon Sep 17 00:00:00 2001 From: dskkato Date: Tue, 20 Aug 2024 23:35:37 +0900 Subject: [PATCH 13/13] re-enable windows --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index daba87fa8a..af96207dd7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -20,7 +20,7 @@ jobs: - ubuntu-latest # TODO(someone): re-enable the following platforms # - macos-latest - # - windows-latest + - windows-latest steps: - uses: actions/checkout@v2 - uses: actions-rs/toolchain@v1 @@ -50,7 +50,7 @@ jobs: - ubuntu-latest # TODO(someone): re-enable the following platforms # - macos-latest - # - windows-latest + - windows-latest steps: - uses: actions/checkout@v2 - uses: actions-rs/toolchain@v1 @@ -76,7 +76,7 @@ jobs: - ubuntu-latest # TODO(someone): re-enable the following platforms # - macos-latest - # - windows-latest + - windows-latest steps: - uses: actions/checkout@v2 - uses: actions-rs/toolchain@v1