Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.1.0 breaks application that do not use apollo client #597

Open
wmlele opened this issue Mar 23, 2022 · 4 comments
Open

4.1.0 breaks application that do not use apollo client #597

wmlele opened this issue Mar 23, 2022 · 4 comments
Assignees
@anehx
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@wmlele
Copy link

wmlele commented Mar 23, 2022

Upgrading to 4.1.0 breaks build of my applications:

ember-simple-auth-oidc tried to import "@apollo/client" in "ember-simple-auth-oidc/apollo.js" but the package was not resolvable from /storage/workspaces/leaf/leaf-sign/node_modules/ember-simple-auth-oidc

Is it intended? is ember-simple-auth-oidc going to require apollo?
@anehx anehx self-assigned this Oct 19, 2022
@anehx
Copy link
Member

anehx commented Oct 19, 2022

Thank you for creating an issue for this @wmlele !

This is not intended. @apollo/client should be an optional peer dependency as specified here:

ember-simple-auth-oidc/package.json

Lines 83 to 90 in 3c69b18

"peerDependencies": {
"@apollo/client": ">= 3.0.0"
},
"peerDependenciesMeta": {
"@apollo/client": {
"optional": true
}
},

I'll take a look at it to figure out why this is causing an error..

@anehx
Copy link
Member

anehx commented Oct 20, 2022

This might be a bug of embroider, I created an issue: embroider-build/embroider#1266

For now, we might have to make @apollo/client a dependency to resolve this issue..

@anehx anehx mentioned this issue Oct 20, 2022
Merged
anehx added a commit to anehx/ember-simple-auth-oidc that referenced this issue Oct 20, 2022
@anehx
fix(apollo): make apollo client a dependency
c917446 
This is necessary since embroider doesn't handle optional dependencies
properly as reported here: embroider-build/embroider#1266

This commit makes `@apollo/client` temporarly a non optional dependency
to fix the current issue we have in apps without that dependency.
However, we need to revert this as soon as the issue above is resolved
since we don't want to enforce this dependency.

Related to adfinis#597
anehx added a commit that referenced this issue Oct 20, 2022
@anehx
fix(apollo): make apollo client a dependency
31aca2e 
This is necessary since embroider doesn't handle optional dependencies
properly as reported here: embroider-build/embroider#1266

This commit makes `@apollo/client` temporarly a non optional dependency
to fix the current issue we have in apps without that dependency.
However, we need to revert this as soon as the issue above is resolved
since we don't want to enforce this dependency.

Related to #597
anehx pushed a commit that referenced this issue Oct 20, 2022
@semantic-release-bot
chore(release): 5.0.1 [skip ci]
373d679 
## [5.0.1](v5.0.0...v5.0.1) (2022-10-20)

### Bug Fixes

* **apollo:** make apollo client a dependency ([31aca2e](31aca2e)), closes [#597](#597)
@anehx
Copy link
Member

anehx commented Oct 20, 2022

This is temporarly fixed in v5.0.1 with #685. However, I'm gonna leave this issue open since we need to revert that PR as soon as embroider fixes its issue.

@bjornharrtell
Copy link
Contributor

FWIW I still need to add graphql as deps to get the build to work with v5.0.3.

@derrabauke derrabauke added bug Something isn't working dependencies Pull requests that update a dependency file labels Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anehx anehx

Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bjornharrtell @wmlele @anehx @derrabauke