Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: You do not have permission to perform this action when stopping an activity #233

Open
1 task done
hairmare opened this issue May 30, 2024 · 3 comments · Fixed by #311
Open
1 task done

[BUG]: You do not have permission to perform this action when stopping an activity #233

hairmare opened this issue May 30, 2024 · 3 comments · Fixed by #311
Labels
backend This issue or pull request is backend related bug Something isn't working

Comments

@hairmare
Copy link
Contributor

hairmare commented May 30, 2024

Description

I'm unable to stop an activity that i started earlier today.

Steps to Reproduce

  1. start activity
  2. wait some time, maybe until the next day
  3. generate worksheet or have the frontend set transferred=True in another way without setting end time
  4. be stuck with an activity that is transferred and therefore can't be edited via the API, that has no to_time and is therefore running, which makes it so no new ones can be started

Expected Behavior

It stops the activity

Attachments

I see the following error in the response to a PATCH req to https://timed.adfinis.com/api/v1/activities/214087

{
  "errors": [
    {
      "detail": "You do not have permission to perform this action.",
      "status": "403",
      "source": {
        "pointer": "/data"
      },
      "code": "permission_denied"
    }
  ]
}

Additional Context

I generated HAR if need be.

It's not logging much on the backend:

Forbidden: /api/v1/activities/214087
403 PATCH /api/v1/activities/214087 (10.100.18.71) 204.12ms

Version

5.1.9

Required

  • I have checked past issues to see if this bug has already been reported.
@hairmare hairmare added bug Something isn't working backend This issue or pull request is backend related labels May 30, 2024
@hairmare hairmare added this to timed May 30, 2024
@hairmare hairmare moved this to 🆕 In Discussion in timed May 30, 2024
@hairmare hairmare moved this from 🆕 In Discussion to 📋 Backlog in timed May 30, 2024
@hairmare
Copy link
Contributor Author

This activity was started before the update to 4.1.9 and i wanted to stop it after the update. Not sure if relevant, but if that was the only issue then we can safely close this issue if it's not something that happens with every update.

@hairmare
Copy link
Contributor Author

I tested this during the 4.1.10 update by starting an activity before the rollout and stopping it afterwards and i wasn't able to reproduce this anymore.

Most likely there was DB change in the last migration that had this impact and this isn't a symptom of each release.

I'm closing this since it doesn't seem actionable anymore now.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in timed May 31, 2024
@c0rydoras c0rydoras reopened this Jun 10, 2024
@c0rydoras
Copy link
Collaborator

This happens nearly every deployment and is starting to annoy me

@hairmare hairmare moved this from ✅ Done to 📋 Backlog in timed Jun 10, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in timed Jul 1, 2024
@c0rydoras c0rydoras moved this from ✅ Done to 👀 In review in timed Jul 2, 2024
@c0rydoras c0rydoras reopened this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This issue or pull request is backend related bug Something isn't working
Projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

2 participants