Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3D blurpooling and code cleanup for 1D and 2D blurpooling #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nihalsid
Copy link

The code had 2D and 1D blurpooling modules which had a lot of code duplicated. Unified that code and added a similar 3D blurpooling module.

Motivation and Context

Adds 3D blurpooling, cleans up code.

How Has This Been Tested?

Compared the outputs of blurpool operators in 2D and 1D for various combination of inputs and parameters to assert that the functionality remains unchanged.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@SungGae
Copy link

SungGae commented Aug 11, 2022

image
I tried to apply it to my 3D model and the following error occurred during the basic test. Can you tell me how to solve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants