Skip to content

Commit 18bb2cb

Browse files
committed
fix(popover): update filter implementation to better match box-shadow
1 parent a38e8a6 commit 18bb2cb

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

components/popover/dist/metadata.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@
104104
"--mod-popover-background-color",
105105
"--mod-popover-border-color",
106106
"--mod-popover-border-width",
107+
"--mod-popover-box-shadow",
107108
"--mod-popover-content-area-spacing",
108109
"--mod-popover-corner-radius",
109110
"--mod-popover-drop-shadow-blur",
@@ -123,6 +124,7 @@
123124
"--spectrum-popover-border-opacity",
124125
"--spectrum-popover-border-transparency",
125126
"--spectrum-popover-border-width",
127+
"--spectrum-popover-box-shadow",
126128
"--spectrum-popover-content-area-spacing",
127129
"--spectrum-popover-corner-radius",
128130
"--spectrum-popover-drop-shadow-blur",

components/popover/index.css

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,12 @@
4949
}
5050

5151
.spectrum-Popover {
52-
--spectrum-popover-filter: drop-shadow(var(--mod-popover-drop-shadow-x, var(--spectrum-popover-drop-shadow-x)) var(--mod-popover-drop-shadow-y, var(--spectrum-popover-drop-shadow-y)) var(--mod-popover-drop-shadow-blur, var(--spectrum-popover-drop-shadow-blur)) var(--mod-popover-drop-shadow-color, var(--spectrum-popover-drop-shadow-color)));
52+
/* filter is for popovers with a tip. we divide the blur by 2 to match the box-shadow rendering better. */
53+
--spectrum-popover-filter: drop-shadow(var(--mod-popover-drop-shadow-x, var(--spectrum-popover-drop-shadow-x)) var(--mod-popover-drop-shadow-y, var(--spectrum-popover-drop-shadow-y)) calc(var(--mod-popover-drop-shadow-blur, var(--spectrum-popover-drop-shadow-blur)) / 2) var(--mod-popover-drop-shadow-color, var(--spectrum-popover-drop-shadow-color)));
54+
55+
/* box-shadow is for popovers without a tip. */
56+
--spectrum-popover-box-shadow: var(--mod-popover-drop-shadow-x, var(--spectrum-popover-drop-shadow-x)) var(--mod-popover-drop-shadow-y, var(--spectrum-popover-drop-shadow-y)) var(--mod-popover-drop-shadow-blur, var(--spectrum-popover-drop-shadow-blur)) var(--mod-popover-drop-shadow-color, var(--spectrum-popover-drop-shadow-color));
57+
5358
@extend %spectrum-overlay;
5459

5560
box-sizing: border-box;
@@ -69,7 +74,7 @@
6974
border-width: var(--mod-popover-border-width, var(--spectrum-popover-border-width));
7075

7176
background-color: var(--mod-popover-background-color, var(--spectrum-popover-background-color));
72-
filter: var(--mod-popover-filter, var(--spectrum-popover-filter));
77+
box-shadow: var(--mod-popover-box-shadow, var(--spectrum-popover-box-shadow));
7378

7479
/* has tip triangle */
7580
&.spectrum-Popover--withTip {

0 commit comments

Comments
 (0)