Skip to content

Commit 842b11f

Browse files
marissahuysentruytcastastrophe
authored andcommitted
fix(statuslight): remove accent variant (#3561)
- removes --spectrum-statuslight-semantic-accent-color from CSS - removes deprecated accent variant from template and tests - adds changeset - update metadata.json
1 parent b9e874a commit 842b11f

File tree

5 files changed

+13
-9
lines changed

5 files changed

+13
-9
lines changed

.changeset/small-impalas-search.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
---
2+
"@spectrum-css/statuslight": patch
3+
---
4+
5+
Removes references to the accent variant, since the accent status light was deprecated in S2.
6+
7+
Removed variant:
8+
9+
`.spectrum-StatusLight--accent`
10+
`--spectrum-statuslight-semantic-accent-color`

components/statuslight/dist/metadata.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@
120120
"--spectrum-statuslight-nonsemantic-silver-color",
121121
"--spectrum-statuslight-nonsemantic-turquoise-color",
122122
"--spectrum-statuslight-nonsemantic-yellow-color",
123-
"--spectrum-statuslight-semantic-accent-color",
124123
"--spectrum-statuslight-semantic-info-color",
125124
"--spectrum-statuslight-semantic-negative-color",
126125
"--spectrum-statuslight-semantic-neutral-color",
@@ -134,7 +133,6 @@
134133
"--spectrum-statuslight-subdued-content-color-default"
135134
],
136135
"global": [
137-
"--spectrum-accent-visual-color",
138136
"--spectrum-blue-visual-color",
139137
"--spectrum-border-width-100",
140138
"--spectrum-brown-visual-color",

components/statuslight/index.css

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@
111111
--spectrum-statuslight-content-color-default: var(--spectrum-neutral-content-color-default);
112112
--spectrum-statuslight-subdued-content-color-default: var(--spectrum-neutral-subdued-content-color-default);
113113
--spectrum-statuslight-semantic-neutral-color: var(--spectrum-neutral-visual-color);
114-
--spectrum-statuslight-semantic-accent-color: var(--spectrum-accent-visual-color);
115114
--spectrum-statuslight-semantic-negative-color: var(--spectrum-negative-visual-color);
116115
--spectrum-statuslight-semantic-info-color: var(--spectrum-informative-visual-color);
117116
--spectrum-statuslight-semantic-notice-color: var(--spectrum-notice-visual-color);
@@ -159,15 +158,14 @@
159158

160159
/* Dot */
161160
&::before {
161+
--spectrum-statuslight-spacing-computed-top-to-dot: calc(var(--mod-statuslight-spacing-top-to-dot, var(--spectrum-statuslight-spacing-top-to-dot)) - var(--mod-statuslight-spacing-top-to-label, var(--spectrum-statuslight-spacing-top-to-label)));
162162
content: "";
163163
flex-grow: 0;
164164
flex-shrink: 0;
165165
display: inline-block;
166166
inline-size: var(--mod-statuslight-dot-size, var(--spectrum-statuslight-dot-size));
167167
block-size: var(--mod-statuslight-dot-size, var(--spectrum-statuslight-dot-size));
168168
border-radius: var(--mod-statuslight-corner-radius, var(--spectrum-statuslight-corner-radius));
169-
170-
--spectrum-statuslight-spacing-computed-top-to-dot: calc(var(--mod-statuslight-spacing-top-to-dot, var(--spectrum-statuslight-spacing-top-to-dot)) - var(--mod-statuslight-spacing-top-to-label, var(--spectrum-statuslight-spacing-top-to-label)));
171169
margin-block-start: var(--spectrum-statuslight-spacing-computed-top-to-dot);
172170
margin-inline-end: var(--mod-statuslight-spacing-dot-to-label, var(--spectrum-statuslight-spacing-dot-to-label));
173171
}
@@ -277,9 +275,9 @@
277275

278276
@media (forced-colors: active) {
279277
.spectrum-StatusLight {
280-
forced-color-adjust: none;
281278
--highcontrast-statuslight-content-color-default: CanvasText;
282279
--highcontrast-statuslight-subdued-content-color-default: CanvasText;
280+
forced-color-adjust: none;
283281

284282
/* Dot */
285283
&::before {

components/statuslight/stories/statuslight.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { Template } from "./template.js";
44
export const StatusLightGroup = Variants({
55
Template,
66
testData: [
7-
...["accent", "info", "positive", "negative", "notice", "neutral"].map((variant) => ({
7+
...["info", "positive", "negative", "notice", "neutral"].map((variant) => ({
88
testHeading: variant.charAt(0).toUpperCase() + variant.slice(1),
99
variant,
1010
})),

components/statuslight/stories/template.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,10 @@ export const Template = ({
2727
</div>
2828
`;
2929

30-
// TODO: the accent variant will be removed in S2.
3130
export const SemanticGroup = (args, context) => Container({
3231
withBorder: false,
3332
direction: "column",
3433
content: html`${[
35-
"accent",
3634
"neutral",
3735
"info",
3836
"negative",

0 commit comments

Comments
 (0)