Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize unittests #14

Open
adrianschlatter opened this issue May 29, 2023 · 1 comment
Open

Reorganize unittests #14

adrianschlatter opened this issue May 29, 2023 · 1 comment

Comments

@adrianschlatter
Copy link
Owner

Structure is rather unsystematic currently.
@adrianschlatter
Copy link
Owner Author

It improved but we have a lot of duplication between text-mode codes => refactor

adrianschlatter added a commit that referenced this issue Sep 15, 2023
@adrianschlatter
DRY up codec tests
bb6a3ce 
The test cases for codecs are almost identically repeated 5 times
=> created a base class for these test cases which is inherited
for each codec.

Had to add full-alphabet test against datamatrix-svg for ascii (as
this was currently missing). Also changed full-alphabet tests of
TEXT and X12: So far, we tested a reduced alphabet against
datamatrix-svg because datamatrix-svg has issues with some characters.
Switched this to testing full alphabet but with ground truth
added "manually".

Modified flake8 exceptions in setup.cfg (import of ppf.datamatrix
appears unused but actually *is* used via codecs).

work on issue #14
adrianschlatter added a commit that referenced this issue Sep 15, 2023
@adrianschlatter
DRY up Codec_Test
e2d1005 
Created a generator function to create test messages
(instead of repeating the same code 3 times).

work on issue #14
adrianschlatter added a commit that referenced this issue Sep 15, 2023
@adrianschlatter
test_consistency.py =into> test_datamatrix.py
afff1b0 
I see no reason why test_consistency.py that tests at the
datamatrix level should not just be part of test_datamatrix.py

work on issue #14
adrianschlatter added a commit that referenced this issue Sep 15, 2023
@adrianschlatter
Clean-up Tests
12392e2 
Migrated "smoke" tests and dropped some of them
(without reducing test coverage).

work on issue #14
adrianschlatter added a commit that referenced this issue Sep 15, 2023
@adrianschlatter
unittest.main()
9e9cb01 
run unittest.main() if called as __main__

closes issue #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adrianschlatter