-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Still maintained? #493
Comments
yap this is concerning |
Agree, at least some level communication from maintainers on what are the plans, is it still maintained or not, would be very helpful. |
Even the basics are broken. There is still no one who cares about this library |
I agree, I wanted to contribute to the docs, I wanted to improve the grammar. And, I saw there was an open discussion about it already, but there was no activity. It does seem like the devs are very busy with personal life stuff or something. |
Time to move on guys, Use Official navigation from Jetbrains |
me myself planning on migration |
and that'd be totally fine and understandable obviously. And they've helped the community so greatly I'm really grateful, I didn't mean this issue to sound anything near unpleasant. |
New beta is out 😄 https://github.com/adrielcafe/voyager/releases/tag/1.1.0-beta03 |
I received a response from the maintainer, and I hope he don’t mind me sharing it here.
|
@nvkleban It's pretty sad there is only one guy working on this, I wish more people could help out maintain this. Otherwise the library is gonna be stagnating. |
Hello! I love Voyager and I just published a fork with rewritten internals that fixes a lot and adds some things. There are some API changes but it has mostly the same API as Voyager. I plan to maintain it in the long term and increasingly add new features. Long live Voyager! 🎉 |
@hristogochev I don't want to give up on Voyager just yet. But you do have some nice changes compared to Voyager. I was struggling with disposing and remembering tabbar screens when navigating away in the navigator above the tabbar. I think by attaching the navigator to a screen that it will probably just work. The transitions also look nice. And the bottom sheet was not always working correctly, by simplifying it, that also seems to be solved. However, I don't like that you forced the default navigation saver. It's fine that it's the default, but I prefer passing objects to the next screen without making them serializable or something. I created a custom saver for Voyager which just saves the list to a Map and it will just revert back to the initial screen when destroyed. Also is there a way to talk in that repo? Issues are of course turned off because it's a fork. I hope some of these changes just end up in Voyager, but in the meantime. I'm not sure what the maintainers think about simplifying the code like you did. But that seems to be the right direction for me to solve a lot of hard to solve issues. Also make it easier to maintain and just let the community create it's own extensions around it. Also I'd like the library to have more "open" stuff. Some stuff like the TabNavigator I had to remake everything because it was not working for me. If it was open, I could've solved it more easily. |
My apologies, I didn't notice that issues are not enabled! I've just enabled them and you can report any issues and suggest things there. |
@hristogochev our solution is probably would be just to migrate to Android Jetpack Navigation, it had some improvements during the past year and finally has some type safety. I actually considered migrating to your fork, but unfortunately we using hilt and screen registry quite extensively. |
It seems issues are growing and we had no new release since June 5th, which makes me believe this library is not maintained anymore. If so, it might be good to disclose it on the readme and/or archive it.
The text was updated successfully, but these errors were encountered: