Fix: update PayPal order status check from 'APPROVED' to 'COMPLETED' …

…and capture order on approval
aelassas · Feb 23, 2025 · 35bd3bd · 35bd3bd
1 parent 8f6911e
commit 35bd3bd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/api/src/controllers/paypalController.ts b/api/src/controllers/paypalController.ts
@@ -72,7 +72,7 @@ export const checkPayPalOrder = async (req: Request, res: Response) => {
     // 2. Update Booking if the payment succeeded
     // (Set BookingStatus to Paid and remove expireAt TTL index)
     //
-    if (order.status === 'APPROVED') {
+    if (order.status === 'COMPLETED') {
       booking.expireAt = undefined
       booking.status = movininTypes.BookingStatus.Paid
       await booking.save()

diff --git a/frontend/src/pages/Checkout.tsx b/frontend/src/pages/Checkout.tsx
@@ -634,9 +634,10 @@ const Checkout = () => {
                               const orderId = await PayPalService.createOrder(bookingId!, price, PaymentService.getCurrency(), name, description)
                               return orderId
                             }}
-                            onApprove={async (data) => {
+                            onApprove={async (data, actions) => {
                               try {
                                 setPayPalProcessing(true)
+                                await actions.order?.capture()
                                 const { orderID } = data
                                 const status = await PayPalService.checkOrder(bookingId!, orderID)