Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Trino notebook #95

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

rahul-aerospike
Copy link
Collaborator

@rahul-aerospike rahul-aerospike commented Jan 19, 2024

Removed notebooks since they do not use our binaries.
Changed the description
Fixed call to presto.connect() Api to work with Trino server 435
Added some headers etc to beautify
Updated the link to trino examples page

@mcoberly2 @reugn @artanderson

Copy link
Collaborator

@mcoberly2 mcoberly2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am puzzled Trino 4.5.0-431 has not been released.
If I approve this will it be merged prematurely?

@rahul-aerospike
Copy link
Collaborator Author

@mcoberly2 I was thinking we will trigger the merge of the branch only after the release. In the meantime, reviewers can approve it. Does it sound OK?

@rahul-aerospike rahul-aerospike changed the title Fix notebook for latest Trino connector 4.5.0 release Remove Trino notebook Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants