Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for clarification and potential improvements: AEX-3 #144

Open
hanssv opened this issue Jan 12, 2022 · 0 comments
Open

Request for clarification and potential improvements: AEX-3 #144

hanssv opened this issue Jan 12, 2022 · 0 comments

Comments

@hanssv
Copy link
Member

hanssv commented Jan 12, 2022

When implementing AEX-3 I noticed a couple of things that could be clarified or described in more detail.

  • Some fields, like kdf-salt, cipher-nonce, and the ciphertext should have a format specification. I would suggest hexadecimal string, but base64, etc. are other alternatives. (And if you really, really want add a format argument and make it configurable - but this just adds complexity in my eyes.)
  • The secret type ed25519-slip0010-masterkey is a bit of a mystery, there is no format specified in SLIP0010, you could perhaps go with the BIP0032 extended key-format, but then make it specific.
  • For the secret type ed25519-bip39-mnemonic string is probably the natural format, but again a hint (and an example?) would help implementers.
  • Or, perhaps just specify further what are allowed values of secret_format (string, raw bytes, base64, hexstring, etc?!)

Also it would be nice with some test vectors - once the above issues are settled/discussed I should be able to provide a bunch of good an bad examples.

aeternity/eaex3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant