Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise helpful error message if event property column already exists #1041

Open
dkrako opened this issue Mar 14, 2025 · 0 comments
Open

raise helpful error message if event property column already exists #1041

dkrako opened this issue Mar 14, 2025 · 0 comments
Labels
bug Something isn't working enhancement New feature or request essential important good first issue Good for newcomers

Comments

@dkrako
Copy link
Contributor

dkrako commented Mar 14, 2025 •
edited
Loading

Description of the problem

If a user calls compute_event_property() for a property that already exists in the event data frame, the raised error is very confusing and not helpful (see #1037).

Description of a solution

A helfpull error message should be raised, that the property is already calculated.

Context

Related issues:
@dkrako dkrako added the enhancement New feature or request label Mar 14, 2025
This was referenced Mar 14, 2025
Open
Open
Closed
@dkrako dkrako added essential important good first issue Good for newcomers bug Something isn't working labels Mar 14, 2025
xiaotiansu added a commit to xiaotiansu/pymovements that referenced this issue Mar 14, 2025
@xiaotiansu
feat: raise helpful error message for existing event properties (aeye…
5ba3a64 
…-lab#1041)
@dkrako dkrako mentioned this issue Mar 17, 2025
Open
19 tasks
xiaotiansu added a commit to xiaotiansu/pymovements that referenced this issue Mar 18, 2025
@xiaotiansu
feat: raise helpful error message for existing event properties (aeye…
80b0d08 
…-lab#1041)

- add type check for event_properties in dataset.py
- add two test cases for ValueError and TypeError in dataset_test.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request essential important good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dkrako