Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading cache behavior #879

Closed
huangy6 opened this issue Feb 9, 2025 · 2 comments
Closed

Misleading cache behavior #879

huangy6 opened this issue Feb 9, 2025 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@huangy6
Copy link

huangy6 commented Feb 9, 2025

Not sure if this is the intended behavior or not, but I had to spend an hour chasing this down when I was expecting my code to make independent generations so I figured I'd mention it in case anyone else ran into this issue

The default value of None for the cache parameter in OpenAIWrapper suggests that caching is disabled by default. (I believe the documentation also suggests that caching has to be explicitly added to be enabled)

However, the default value of LEGACY_DEFAULT_CACHE_SEED for cache_seed in OpenAIWrapper.create() leads cache_client be set by default.

Again, I'm not sure if this is the intended behavior, but either way I think it would be helpful if the documentation were more clear about cache behavior.

@davorrunje
Copy link
Collaborator

@huangy6 Hi, you are right about this not being properly documented and properly logged so you are at least aware of what is going on.

@davorrunje davorrunje added the documentation Improvements or additions to documentation label Feb 10, 2025
@davorrunje davorrunje added this to ag2 Feb 10, 2025
@kumaranvpl kumaranvpl moved this to Todo in ag2 Feb 11, 2025
@kumaranvpl kumaranvpl moved this from Todo to In Progress in ag2 Feb 17, 2025
@davorrunje davorrunje moved this from In Progress to Waiting for merge in ag2 Feb 17, 2025
@kumaranvpl
Copy link
Collaborator

Fixed by the PR - #994

@github-project-automation github-project-automation bot moved this from Waiting for merge to Done in ag2 Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

No branches or pull requests

3 participants