Skip to content

Release v2.1.1 #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JacquesCarette opened this issue Aug 16, 2024 · 22 comments
Closed

Release v2.1.1 #2461

JacquesCarette opened this issue Aug 16, 2024 · 22 comments
Labels
upstream Changes induced by Agda upstream
Milestone

Comments

@JacquesCarette
Copy link
Contributor

Now that it is finally released, we should make sure we're compatible with it (both to see if v2.1 is, and current development/v2.2 is). If memory serves me correctly, neither are - but we should make sure all appropriate wikis are clear about that!

@JacquesCarette
Copy link
Contributor Author

(I was looking at what labels to add to this, and didn't see anything that fit all that well?)

@andreasabel andreasabel added the upstream Changes induced by Agda upstream label Aug 16, 2024
@jamesmckinna
Copy link
Contributor

jamesmckinna commented Aug 16, 2024

Now that it is finally released, we should make sure we're compatible with it (both to see if v2.1 is, and current development/v2.2 is). If memory serves me correctly, neither are - but we should make sure all appropriate wikis are clear about that!

Oh no!

At least as far as v2.1 is concerned, it should simply be badged as compatible with v2.6.4.3... but that does put pressure on us to make v2.2 release (!) to be 'eventually compatible' with 2.7? Can we fix this up at release time, or will the CI for new commits on existing PRs expect, in particular --exact-split? This may very well be a major source of breaking... sigh ;-)

But as for my current v2.2 developments, I'm not quite ready to make the 'great leap forward'... yet!

@andreasabel
Copy link
Member

Could you release 2.1.1 instead with just the minimal fixes over 2.1 for Agda 2.7.0? (Some fixes are on the experimental branch.)

@JacquesCarette
Copy link
Contributor Author

That was implicitly my goal with this issue, i.e. get a 2.1.1 release out if it's needed (and then folding that into 2.2), and indeed experimental is already (partway?) there.

@iblech
Copy link
Contributor

iblech commented Aug 19, 2024

I just checked: Just two commits from the experimental branch need to be cherry-picked to tag v2.1 in order to establish compatibility with Agda 2.7.0: 586f56a and c7d65e0

@MatthewDaggitt
Copy link
Contributor

MatthewDaggitt commented Aug 19, 2024 via email

@MatthewDaggitt MatthewDaggitt changed the title Compatibility with agda-2.7 Release v2.1.1 Aug 20, 2024
@MatthewDaggitt MatthewDaggitt added this to the v2.2.1 milestone Aug 20, 2024
@MatthewDaggitt
Copy link
Contributor

Created the first release candidate.

@MatthewDaggitt
Copy link
Contributor

Second release candidate created

@mechvel
Copy link
Contributor

mechvel commented Aug 21, 2024

I try testing lib-2.1.1-rc2 on my large application.
I type-checks everything.
But I also test compilation examples to executable.
And this produces internal error due to a bug in Agda 2.7.0 (see news in the Agda bug tracker).
Therefore I cannot reliably test lib-2.1.1-rc2 before this bug in Agda is fixed.

@mechvel
Copy link
Contributor

mechvel commented Aug 21, 2024

More precisely, it is compiled by a certain sequence of type-check-compile commands and produces "internal error" for another sequence.
Most probably this effect does depend on the standard library version.

@andreasabel
Copy link
Member

@mechvel wrote:

And this produces internal error due to a bug in Agda 2.7.0

This refers to

One would speculate that it is a regression in the .agdai creation. I do not think it is related to the standard library.

@jamesmckinna
Copy link
Contributor

Milestone is v2.2.1? Rather than v2.1.1?

@JacquesCarette
Copy link
Contributor Author

I think that's just a typo, I'll see if I can fix it.

@MatthewDaggitt
Copy link
Contributor

I've made the release. @gallais any chance you could generate and upload the website docs? I still can't get it running on my computer 😢

@jamesmckinna
Copy link
Contributor

@MatthewDaggitt @gallais I've just tried following the release-guide.txt instructions, and had several/many problems, so suggest raising a separate continuous-integration/admin issue?
In short order, working with the supplied instructions:

  • cabal run GenerateEverything.hs should be superseded by make setup, since we moved the Everything* files to doc (also, for my version of cabal, it objects, suggesting instead cabal run GenerateEverything, which does work, but is out of step with the new destination for the generated files...)
  • git checkout gh-pages falls over, because of clashes between that branch and, AFAICT, on all the files added/updated since the v2.1 release... did we fail to update the gh-pages branch after the v2.1 release? or is something else broken?

At that point, I bailed...

@gallais
Copy link
Member

gallais commented Sep 3, 2024

It should have landed now: https://agda.github.io/agda-stdlib/

@jamesmckinna
Copy link
Contributor

Out of interest, @gallais , were you able to diagnose how/why Matthew and I were having problems as above?

@gallais
Copy link
Member

gallais commented Sep 3, 2024

I had similar issues with cabal but I do not dare to suggest a solution as everyone seems
to have a different version using a different mechanism to run scripts.

I don't know why the location of the EverythingX.agda files would matter given the command
line to generate the html includes all of -i. -idoc -isrc. It could be you had stray files left in the
doc/ directory?

I don't know why anything would fall over when you checkout gh-pages.

@jamesmckinna
Copy link
Contributor

Thanks @gallais I may try a fresh clone after merging #2473 ...

@jamesmckinna jamesmckinna linked a pull request Sep 7, 2024 that will close this issue
@jamesmckinna jamesmckinna removed a link to a pull request Sep 7, 2024
@jamesmckinna
Copy link
Contributor

I got myself confused as to whether this issue is closed by #2473 or not...

@MatthewDaggitt
Copy link
Contributor

It was closed by @gallais uploading the release branch 😄 Rebasing master so that it includes the changes from v2.1.1 is not per se part of the release process I think...

@MatthewDaggitt
Copy link
Contributor

Thanks everyone for their work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Changes induced by Agda upstream
Projects
None yet
Development

No branches or pull requests

7 participants