Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: scan is always enabled as long as showToolbar is true #269

Open
Jesperpaulsen opened this issue Feb 19, 2025 · 3 comments
Open

Bug: scan is always enabled as long as showToolbar is true #269

Jesperpaulsen opened this issue Feb 19, 2025 · 3 comments
Assignees

Comments

@Jesperpaulsen
Copy link

On the toolbar property it says:

Show toolbar bar

If you set this to true, and set enabled to false, the toolbar will still show, but scanning will be disabled.

@default

true

But if you do:

scan({ enabled: false, showToolbar: true });

scan is still enabled by default.

@pivanov
Copy link
Collaborator

pivanov commented Feb 19, 2025

Hey @Jesperpaulsen
do you use the npm packge or https://unpkg.com/react-scan/dist/auto.global.js?
These changes are not released yet will be available in next version (we will release it next days)

@pivanov pivanov self-assigned this Feb 19, 2025
@Jesperpaulsen
Copy link
Author

I use the npm package. Version 0.1.3.

@pivanov
Copy link
Collaborator

pivanov commented Feb 21, 2025

This will be fixed in next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants