Click version 7.1 breaks test and verdi-autodocs pre-commit hook

[csadorf]

The click version 7.1 (released a few hours ago) breaks test and verdi-autodocs pre-commit hook.

As an immediate measure, I recommend to pin the Click version to 7.0 (#3837 ).

[sphuber]

Do you remember what the problem was exactly? I tried to unpin and verdi-autodocs ran just fine with the new version of click. It just has some other setting regarding to the help string formatting, so it changed some of the generated auto docs.

[greschd]

Might be unrelated, but click version 7.1 had broken its error messages (they went to stdout instead of stderr). The fixed 7.1.1 was released just a few hours after, but not before the issue mentioned above.

If I remember correctly I did try to run the tests again with 7.1.1 and it was still broken, but I didn't test that thoroughly.

[sphuber]

The problem is due to this PR of click. They wrapped the editor command in shlex_quote. Since in our unit testing we pass arguments to the editor command to make it non-interactive, this is now interpreted as a single executable by bash which it then fails to find. We might have to find another way to simulate the interactivity of these tests without abusing the os.environ['EDITOR'] variable.

Edit: and we are also affected by this issue.