From acf29ce600581cc42a779d999510fc09ea3078be Mon Sep 17 00:00:00 2001 From: Sam Bull Date: Sun, 19 Nov 2023 14:37:41 +0000 Subject: [PATCH] Apply suggestions from code review --- aiohttp_devtools/logs.py | 2 +- aiohttp_devtools/runserver/serve.py | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/aiohttp_devtools/logs.py b/aiohttp_devtools/logs.py index 3087d528..53683d26 100644 --- a/aiohttp_devtools/logs.py +++ b/aiohttp_devtools/logs.py @@ -80,7 +80,7 @@ def formatMessage(self, record: logging.LogRecord) -> str: def formatException(self, ei: _Ei) -> str: sio = StringIO() - traceback.print_exception(*ei, file=sio) + traceback.print_exception(*ei, file=sio) # type: ignore[misc] stack = sio.getvalue() sio.close() if self.stream_is_tty and pyg_lexer: diff --git a/aiohttp_devtools/runserver/serve.py b/aiohttp_devtools/runserver/serve.py index f5c36c2c..1c9a5134 100644 --- a/aiohttp_devtools/runserver/serve.py +++ b/aiohttp_devtools/runserver/serve.py @@ -27,7 +27,7 @@ try: from aiohttp_jinja2 import static_root_key except ImportError: - static_root_key = None + static_root_key = None # type: ignore[assignment] LIVE_RELOAD_HOST_SNIPPET = '\n\n' LIVE_RELOAD_LOCAL_SNIPPET = b'\n\n' @@ -41,20 +41,20 @@ def _set_static_url(app: web.Application, url: str) -> None: if static_root_key is None: # TODO: Remove fallback - with warnings.catch_warnings(): + with warnings.catch_warnings(): # type: ignore[unreachable] app["static_root_url"] = MutableValue(url) else: - app[static_root_key] = MutableValue(url) + app[static_root_key] = MutableValue(url) # type: ignore[misc] for subapp in app._subapps: _set_static_url(subapp, url) def _change_static_url(app: web.Application, url: str) -> None: if static_root_key is None: # TODO: Remove fallback - with warnings.catch_warnings(): + with warnings.catch_warnings(): # type: ignore[unreachable] app["static_root_url"].change(url) else: - app[static_root_key].change(url) + app[static_root_key].change(url) # type: ignore[attr-defined] for subapp in app._subapps: _change_static_url(subapp, url)