Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl support #712

Merged
merged 35 commits into from
Feb 4, 2025
Merged

ssl support #712

merged 35 commits into from
Feb 4, 2025

Conversation

zrvku2000
Copy link
Contributor

@zrvku2000 zrvku2000 commented Jan 22, 2025

What do these changes do?

implements ssl support

Are there changes in behavior for the user?

no

Related issue number

Fixes #208

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

Sorry, something went wrong.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (dd571e6) to head (5e45226).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
+ Coverage   95.85%   96.49%   +0.63%     
==========================================
  Files          23       23              
  Lines        1714     1852     +138     
  Branches      198      110      -88     
==========================================
+ Hits         1643     1787     +144     
+ Misses         46       43       -3     
+ Partials       25       22       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer
Copy link
Member

Thanks, looking good. Just need to review the test failures and coverage.

@zrvku2000
Copy link
Contributor Author

zrvku2000 commented Jan 29, 2025

2.2.1 version of 'livereload.js' doesn't check browser's 'location.protocol' property and always uses 'ws' specification for handshake. So aux server reverted to http.

@Dreamsorcerer
Copy link
Member

One test still failing. I'd suggest moving the test to test_runserver_main.py as well, I don't think we need a dedicated ssl file for it.

@zrvku2000
Copy link
Contributor Author

zrvku2000 commented Feb 1, 2025

Windows tests are failing... Didn't even check that for this os... Ok, I'll check and correct them on VM. This may be problem with self-signed test certs...

@zrvku2000
Copy link
Contributor Author

Tests for Linux, Linux PyPy, MacOS and Windows perform well in my local environment.

@Dreamsorcerer Dreamsorcerer merged commit 0880b35 into aio-libs:master Feb 4, 2025
18 checks passed
@Dreamsorcerer
Copy link
Member

Thanks for that, seemed to be a fair bit more complex than I expected.

@zrvku2000 zrvku2000 deleted the ssl_support branch February 5, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Features Request: Add HTTPS Support
2 participants