-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssl support #712
ssl support #712
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #712 +/- ##
==========================================
+ Coverage 95.85% 96.49% +0.63%
==========================================
Files 23 23
Lines 1714 1852 +138
Branches 198 110 -88
==========================================
+ Hits 1643 1787 +144
+ Misses 46 43 -3
+ Partials 25 22 -3 ☔ View full report in Codecov by Sentry. |
Thanks, looking good. Just need to review the test failures and coverage. |
…test_runserver_with_ssl, pytest-datafiles requirements plugin
2.2.1 version of 'livereload.js' doesn't check browser's 'location.protocol' property and always uses 'ws' specification for handshake. So aux server reverted to http. |
One test still failing. I'd suggest moving the test to test_runserver_main.py as well, I don't think we need a dedicated ssl file for it. |
Windows tests are failing... Didn't even check that for this os... Ok, I'll check and correct them on VM. This may be problem with self-signed test certs... |
Tests for Linux, Linux PyPy, MacOS and Windows perform well in my local environment. |
Thanks for that, seemed to be a fair bit more complex than I expected. |
What do these changes do?
implements ssl support
Are there changes in behavior for the user?
no
Related issue number
Fixes #208
Checklist