Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move all description fields to the BaseModel #51

Open
aiqc opened this issue Apr 4, 2021 · 0 comments
Open

move all description fields to the BaseModel #51

aiqc opened this issue Apr 4, 2021 · 0 comments
Labels
good first issue Good for newcomers refactor Make code more modular/efficient or change schema.

Comments

@aiqc
Copy link
Owner

aiqc commented Apr 4, 2021 •
edited
Loading

Difficulty: ★☆☆☆☆

Background

BaseModel applies to all ORM classes. Right now we have description = CharField(null=True) in some but not all individual ORM classes.

Problem

It's redundant and inconsistent.

Solution

move description to BaseModel and remove it from all individual classes
@aiqc aiqc added good first issue Good for newcomers refactor Make code more modular/efficient or change schema. labels Apr 4, 2021
@aiqc aiqc assigned aiqc and unassigned aiqc Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor Make code more modular/efficient or change schema.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aiqc