Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better documentation for tags #11

Open
alexism opened this issue Jun 30, 2015 · 1 comment
Open

better documentation for tags #11

alexism opened this issue Jun 30, 2015 · 1 comment
Assignees

Comments

@alexism
Copy link
Contributor

alexism commented Jun 30, 2015

Kafka 0.8.2 refactored its metrics to use tags/scopes. See https://issues.apache.org/jira/browse/KAFKA-1481

In 0.4.0, `kafka-statsd-metrics21 introduced support for metric tags. Tags are an extension to the Statsd protocol introduced by Datadog, see http://docs.datadoghq.com/guides/dogstatsd/#tags.

By default, tags are added to the generated statsd metrics, but people using a Statsd server that does not support tags are confused.

The documentation should make these details more obvious and have clear explanation on how to disable tags. Examples of metrics generated when tags are off will also be useful.

@gdubicki
Copy link

+1

Only when I read this particular comment #9 (comment) I undestood how will your lib work with a standard, non-datadog statsd.

It woud be really nice if the docs were more clear on this subject then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants