Skip to content

Commit 87e899f

Browse files
committed
Prefer explicit return in this short method
1 parent 6eb9453 commit 87e899f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/qa/runner/ruby/ruby.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ func (self *context) EnumerateTests() (traceEvents []tapjio.TraceEvent, testRunn
124124
traceEvents = append(traceEvents, trace)
125125
return
126126
},
127-
OnTest: func(test tapjio.TestEvent) (err error) {
127+
OnTest: func(test tapjio.TestEvent) error {
128128
if cfg.SquashPolicy == SquashNothing ||
129129
cfg.SquashPolicy == SquashByFile && (currentRunner == nil || currentRunner.file != test.File) ||
130130
cfg.SquashPolicy == SquashAll && currentRunner == nil {
@@ -138,7 +138,7 @@ func (self *context) EnumerateTests() (traceEvents []tapjio.TraceEvent, testRunn
138138
}
139139
}
140140
currentRunner.filters = append(currentRunner.filters, test.Filter)
141-
return
141+
return nil
142142
},
143143
OnEnd: func(reason error) error {
144144
if currentRunner != nil {

0 commit comments

Comments
 (0)