JWT Signing #212
Merged
JWT Signing #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-hughes
reviewed
Oct 29, 2024
evan-hughes
reviewed
Oct 29, 2024
|
Thanks @evan-hughes, changes are made. |
evan-hughes
reviewed
Oct 30, 2024
evan-hughes
reviewed
Oct 30, 2024
…along with details on output types.
evan-hughes
reviewed
Nov 1, 2024
| - `ext`: Indicates if the key is extractable (`true` in this case). | ||
|
|
||
| Take note that the main.js version uses `raw` key format. If using `jwk` in the example above, the stringified console output of `jwkKey` above may be pasted directly into the Property Manager variable `PMUSER_JWT_HMAC_KEY`. | ||
|
|
There was a problem hiding this comment.
This is a great explanation! Thanks!
|
Looks good to me. I'll ping a couple of other folks on the team for another review, but we should be ready to merge shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edgeworker example added for signing JWTs.