-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish refactoring of provider/network statistic #665
Comments
stalniy
added a commit
that referenced
this issue
Jan 17, 2025
stalniy
added a commit
that referenced
this issue
Jan 17, 2025
stalniy
added a commit
that referenced
this issue
Jan 18, 2025
stalniy
added a commit
that referenced
this issue
Jan 18, 2025
stalniy
added a commit
that referenced
this issue
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Why
Currently provider statistic is aggregate per type (e.g.,
activeStats
,pendingStats
) and it makes it harder to work with this data structure. It's harder to pass all needed details for one entry. For example, to display (or to work with) CPU/GPU related information I need the wholeProvider
because their stat values are in 3 different objects.That's why I'd like to change how it's aggregated, better to aggregate per metric and then each metric has all needed values inside. Additionally, this helps to manage changes because if we want to remove metric - we remove it from single place (not in many other objects). If we want to add metric, it's also easy
What
New stats object:
Currently used stats object:
DO NOT remove the previous ones immediately, because some people may use cached version of console-web. Keep old values in place for a week or so
Acceptance
/network-capacity
route should change response to match new structure/providers/{address}
should expose newstats
property that adheres to the new shape above/providers
should expose newstats
property that adheres to the new shape aboveThe text was updated successfully, but these errors were encountered: